[DevTools] Migrate DevToolsTracingHandler to generated handler.

[DevTools] Migrate DevToolsTracingHandler to generated handler.

This patch also adds SendRawMessage, which is used for performance
in tracing handler.

BUG=405566
Committed: https://crrev.com/1b3d5f311e8f4fd6ff4352fec7e0dee303f2a322
Cr-Commit-Position: refs/heads/master@{#300861}

[dgozman, 2014-10-07 12:09:32]

dgozman@chromium.org changed reviewers:
+ caseq@chromium.org, vkuzkokov@chromium.org

[dgozman, 2014-10-07 12:09:33]

Take a look please. This is mostly a code move.

[vkuzkokov, 2014-10-07 13:36:08]

lgtm with nit.

https://codereview.chromium.org/635733003/diff/20001/content/browser/devtools...
File content/browser/devtools/protocol/tracing_handler.cc (right):

https://codereview.chromium.org/635733003/diff/20001/content/browser/devtools...
content/browser/devtools/protocol/tracing_handler.cc:110: return NULL;
Consider using nullptr in this file.

[dgozman, 2014-10-13 12:03:07]

friendly ping

[caseq, 2014-10-13 13:01:27]

https://codereview.chromium.org/635733003/diff/20001/content/browser/devtools...
File content/browser/devtools/protocol/devtools_protocol_client.h (right):

https://codereview.chromium.org/635733003/diff/20001/content/browser/devtools...
content/browser/devtools/protocol/devtools_protocol_client.h:66: const
RawMessageCallback& raw_message_callback);
Let's have one callback instead of three, i.e. just RawMessageCallback and
implement others on top of it.

https://codereview.chromium.org/635733003/diff/20001/content/browser/devtools...
File content/browser/devtools/protocol/tracing_handler.cc (right):

https://codereview.chromium.org/635733003/diff/20001/content/browser/devtools...
content/browser/devtools/protocol/tracing_handler.cc:159: for (const auto&
category : category_set)
consider using range constructor for categories instead?

https://codereview.chromium.org/635733003/diff/20001/content/browser/devtools...
File content/browser/devtools/protocol/tracing_handler.h (right):

https://codereview.chromium.org/635733003/diff/20001/content/browser/devtools...
content/browser/devtools/protocol/tracing_handler.h:66: static const char*
kDefaultCategories;
Do we need these exposed in the header file? Use anonymous namespace in the .cc
file instead?

https://codereview.chromium.org/635733003/diff/20001/content/browser/devtools...
File content/browser/devtools/render_view_devtools_agent_host.h (right):

https://codereview.chromium.org/635733003/diff/20001/content/browser/devtools...
content/browser/devtools/render_view_devtools_agent_host.h:16: #include
"content/browser/devtools/protocol/tracing_handler.h"
why not keep forward declaration instead? propagating dependencies on generated
code seems a bit unfortunate.

[dgozman, 2014-10-14 12:42:22]

PTAL

https://codereview.chromium.org/635733003/diff/20001/content/browser/devtools...
File content/browser/devtools/protocol/devtools_protocol_client.h (right):

https://codereview.chromium.org/635733003/diff/20001/content/browser/devtools...
content/browser/devtools/protocol/devtools_protocol_client.h:66: const
RawMessageCallback& raw_message_callback);
On 2014/10/13 13:01:27, caseq wrote:
> Let's have one callback instead of three, i.e. just RawMessageCallback and
> implement others on top of it.

Done.

https://codereview.chromium.org/635733003/diff/20001/content/browser/devtools...
File content/browser/devtools/protocol/tracing_handler.cc (right):

https://codereview.chromium.org/635733003/diff/20001/content/browser/devtools...
content/browser/devtools/protocol/tracing_handler.cc:110: return NULL;
On 2014/10/07 13:36:07, vkuzkokov wrote:
> Consider using nullptr in this file.

Done.

https://codereview.chromium.org/635733003/diff/20001/content/browser/devtools...
content/browser/devtools/protocol/tracing_handler.cc:159: for (const auto&
category : category_set)
On 2014/10/13 13:01:27, caseq wrote:
> consider using range constructor for categories instead?

Done.

https://codereview.chromium.org/635733003/diff/20001/content/browser/devtools...
File content/browser/devtools/protocol/tracing_handler.h (right):

https://codereview.chromium.org/635733003/diff/20001/content/browser/devtools...
content/browser/devtools/protocol/tracing_handler.h:66: static const char*
kDefaultCategories;
On 2014/10/13 13:01:27, caseq wrote:
> Do we need these exposed in the header file? Use anonymous namespace in the
.cc
> file instead?

We don't. I just moved this code as it was before. In fact, only one of these is
ever used. Moved to cc.

https://codereview.chromium.org/635733003/diff/20001/content/browser/devtools...
File content/browser/devtools/render_view_devtools_agent_host.h (right):

https://codereview.chromium.org/635733003/diff/20001/content/browser/devtools...
content/browser/devtools/render_view_devtools_agent_host.h:16: #include
"content/browser/devtools/protocol/tracing_handler.h"
On 2014/10/13 13:01:27, caseq wrote:
> why not keep forward declaration instead? propagating dependencies on
generated
> code seems a bit unfortunate.

Done.

[dgozman, 2014-10-16 10:33:59]

ping

[caseq, 2014-10-16 12:07:21]

lgtm with nits

https://codereview.chromium.org/635733003/diff/70001/content/browser/devtools...
File content/browser/devtools/protocol/tracing_handler.cc (right):

https://codereview.chromium.org/635733003/diff/70001/content/browser/devtools...
content/browser/devtools/protocol/tracing_handler.cc:78: message += "] } }",
client_->SendRawMessage(message);
please fix formatting here!

https://codereview.chromium.org/635733003/diff/70001/content/browser/devtools...
File content/browser/devtools/render_view_devtools_agent_host.h (right):

https://codereview.chromium.org/635733003/diff/70001/content/browser/devtools...
content/browser/devtools/render_view_devtools_agent_host.h:35: namespace dom {
here and below, collapse namespace ... { class ... } into one line for better
readability.

[dgozman, 2014-10-17 13:53:08]

https://codereview.chromium.org/635733003/diff/70001/content/browser/devtools...
File content/browser/devtools/protocol/tracing_handler.cc (right):

https://codereview.chromium.org/635733003/diff/70001/content/browser/devtools...
content/browser/devtools/protocol/tracing_handler.cc:78: message += "] } }",
client_->SendRawMessage(message);
On 2014/10/16 12:07:21, caseq wrote:
> please fix formatting here!

Done.

https://codereview.chromium.org/635733003/diff/70001/content/browser/devtools...
File content/browser/devtools/render_view_devtools_agent_host.h (right):

https://codereview.chromium.org/635733003/diff/70001/content/browser/devtools...
content/browser/devtools/render_view_devtools_agent_host.h:35: namespace dom {
On 2014/10/16 12:07:21, caseq wrote:
> here and below, collapse namespace ... { class ... } into one line for better
> readability.

Done.

[dgozman, 2014-10-17 13:53:12]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-10-17 13:53:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/635733003/110001

[commit-bot: I haz the power, 2014-10-17 14:59:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-17 14:59:11]

Try jobs failed on following builders:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vkuzkokov, 2014-10-20 15:05:30]

On 2014/10/17 14:59:11, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   linux_chromium_rel_swarming on tryserver.chromium.linux
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

FYI: this happens because parameter |categories| in |Tracing.start| is marked
required in protocol.json but Telemetry doesn't send it.

[dgozman, 2014-10-22 07:39:26]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-10-22 07:40:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/635733003/130001

[commit-bot: I haz the power, 2014-10-22 07:47:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-22 07:47:36]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[dgozman, 2014-10-22 12:51:37]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-10-22 12:52:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/635733003/130001

[commit-bot: I haz the power, 2014-10-22 16:14:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/635733003/130001

[commit-bot: I haz the power, 2014-10-22 18:28:12]

Committed patchset #6 (id:130001)

[commit-bot: I haz the power, 2014-10-22 18:28:57]

Patchset 6 (id:??) landed as
https://crrev.com/f7762cb9261c8e2e15f2cf2b36f5408c75d72bdd
Cr-Commit-Position: refs/heads/master@{#300711}

[Devlin, 2014-10-22 19:14:02]

A revert of this CL (patchset #6 id:130001) has been created in
https://codereview.chromium.org/675473005/ by rdevlin.cronin@chromium.org.

The reason for reverting is: Broke compile, e.g.
http://build.chromium.org/p/chromium.gpu/builders/GPU%20Linux%20Builder/build....
FAILED: /b/build/goma/gomacc
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/content/gen/content/browser/devtools/protocol/content_browser.devtools_protocol_handler_impl.o.d
-DCONTENT_IMPLEMENTATION -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64
-DCHROMIUM_BUILD -DCR_CLANG_REVISION=218707 -DTOOLKIT_VIEWS=1
-DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1
-DUSE_CAIRO=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1
-DUSE_CLIPBOARD_AURAX11=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP
-DUSE_XI2_MT=2 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS
-DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DUSE_UDEV
-DDCHECK_ALWAYS_ON=1 -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1
-DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1
-DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1
-DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DCLD2_DATA_SOURCE=static
-DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1
-DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1
-DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1
-DENABLE_LOAD_COMPLETION_HACKS=1 -DENABLE_SCREEN_CAPTURE=1 -DGL_GLEXT_PROTOTYPES
-DMOJO_USE_SYSTEM_IMPL -DLIBPEERCONNECTION_LIB=1 -DSK_ENABLE_INST_COUNT=0
-DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"'
-DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1
-DGR_GL_IGNORE_ES3_MSAA=0 -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT
-DSK_SUPPORT_LEGACY_TEXTRENDERMODE -DSK_LEGACY_NO_DISTANCE_FIELD_PATHS
-DSK_USE_POSIX_THREADS -DSK_DEFERRED_CANVAS_USES_FACTORIES=1
-DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION
-DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI
-DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DCHROME_PNG_WRITE_SUPPORT
-DPNG_USER_CONFIG -DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL
-DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING
-DNO_SOUND_SYSTEM -DLINUX -DWEBRTC_LINUX -DPOSIX -DWEBRTC_POSIX
-DWEBRTC_CHROMIUM_BUILD -DFLAC__NO_DLL -DUSE_GLIB=1 -DUSE_NSS=1
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND
-DDYNAMIC_ANNOTATIONS_ENABLED=0 -Igen -I../.. -Iobj/content/content_browser.gen
-I../../third_party/khronos -I../../gpu -I../../skia/config
-I../../third_party/WebKit/Source -Igen/angle -I../../net/third_party/nss/ssl
-I../../third_party/skia/src/core -I../../third_party/skia/include/core
-I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf
-I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy
-I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe
-I../../third_party/skia/include/ports -I../../third_party/skia/include/utils
-I../../skia/ext -I../../third_party/re2 -I../../third_party/zlib
-I../../third_party/WebKit -I../../third_party/icu/source/i18n
-I../../third_party/icu/source/common -Igen/ui/resources -Igen/protoc_out
-I../../third_party/protobuf -I../../third_party/protobuf/src
-Igen/content/app/resources/ -Igen/webkit
-I../../third_party/leveldatabase/src/include
-I../../third_party/leveldatabase/src -I../../third_party/leveldatabase
-I../../third_party/WebKit -I../../third_party/npapi
-I../../third_party/npapi/bindings -I../../v8/include -I../../third_party/libpng
-I../../third_party/libwebp -I../../third_party/ots/include
-I../../third_party/qcms/src -I../../third_party/iccjpeg
-I../../third_party/libjpeg_turbo -Igen/content/browser/tracing
-I../../third_party/libyuv/include -I../../third_party/libyuv
-I../../third_party/webrtc/overrides -I../../third_party/libjingle/overrides
-I../../third_party/libjingle/source -I../../testing/gtest/include
-I../../third_party -I../../third_party/speex/include -fstack-protector
--param=ssp-buffer-size=4 -Werror -pthread -fno-strict-aliasing -Wall
-Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe
-fPIC -Wno-reserved-user-defined-literal -Xclang -load -Xclang
/b/build/slave/GPU_Linux_Builder/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so
-Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics
-B/b/build/slave/GPU_Linux_Builder/build/src/third_party/binutils/Linux_x64/Release/bin
-Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration
-Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing
-Wno-deprecated-register -Wno-unused-local-typedef -Wexit-time-destructors
-pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include
-I/usr/include/nss -I/usr/include/nspr -Wno-header-guard -pthread
-I/usr/include/pango-1.0 -I/usr/include/cairo -I/usr/include/glib-2.0
-I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1
-I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/dbus-1.0
-I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -m64 -march=x86-64 -O2 -fno-ident
-fdata-sections -ffunction-sections -funwind-tables -fno-exceptions -fno-rtti
-fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -std=gnu++11 
-c gen/content/browser/devtools/protocol/devtools_protocol_handler_impl.cc -o
obj/content/gen/content/browser/devtools/protocol/content_browser.devtools_protocol_handler_impl.o
gen/content/browser/devtools/protocol/devtools_protocol_handler_impl.cc:951:7:
error: no viable conversion from 'std::string' (aka 'basic_string<char>') to
'const std::string *' (aka 'const basic_string<char> *')
      in_categories,
      ^~~~~~~~~~~~~
../../content/browser/devtools/protocol/tracing_handler.h:40:26: note: passing
argument to parameter 'categories' here
      const std::string* categories,
                         ^
1 error generated.
ninja: build stopped: subcommand failed..

[Devlin, 2014-10-22 19:46:09]

On 2014/10/22 19:14:02, Devlin wrote:
> A revert of this CL (patchset #6 id:130001) has been created in
> https://codereview.chromium.org/675473005/ by
mailto:rdevlin.cronin@chromium.org.
> 
> The reason for reverting is: Broke compile, e.g.
>
http://build.chromium.org/p/chromium.gpu/builders/GPU%20Linux%20Builder/build....
> FAILED: /b/build/goma/gomacc
> ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
>
obj/content/gen/content/browser/devtools/protocol/content_browser.devtools_protocol_handler_impl.o.d
> -DCONTENT_IMPLEMENTATION -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64
> -DCHROMIUM_BUILD -DCR_CLANG_REVISION=218707 -DTOOLKIT_VIEWS=1
> -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1
> -DUSE_CAIRO=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1
> -DUSE_CLIPBOARD_AURAX11=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP
> -DUSE_XI2_MT=2 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS
> -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DUSE_UDEV
> -DDCHECK_ALWAYS_ON=1 -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1
> -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1
> -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1
> -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DCLD2_DATA_SOURCE=static
> -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1
> -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1
-DENABLE_SETTINGS_APP=1
> -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1
> -DENABLE_LOAD_COMPLETION_HACKS=1 -DENABLE_SCREEN_CAPTURE=1
-DGL_GLEXT_PROTOTYPES
> -DMOJO_USE_SYSTEM_IMPL -DLIBPEERCONNECTION_LIB=1 -DSK_ENABLE_INST_COUNT=0
> -DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"'
> -DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1
> -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT
> -DSK_SUPPORT_LEGACY_TEXTRENDERMODE -DSK_LEGACY_NO_DISTANCE_FIELD_PATHS
> -DSK_USE_POSIX_THREADS -DSK_DEFERRED_CANVAS_USES_FACTORIES=1
> -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION
> -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI
> -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DCHROME_PNG_WRITE_SUPPORT
> -DPNG_USER_CONFIG -DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL
> -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING
> -DNO_SOUND_SYSTEM -DLINUX -DWEBRTC_LINUX -DPOSIX -DWEBRTC_POSIX
> -DWEBRTC_CHROMIUM_BUILD -DFLAC__NO_DLL -DUSE_GLIB=1 -DUSE_NSS=1
> -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND
> -DDYNAMIC_ANNOTATIONS_ENABLED=0 -Igen -I../..
-Iobj/content/content_browser.gen
> -I../../third_party/khronos -I../../gpu -I../../skia/config
> -I../../third_party/WebKit/Source -Igen/angle -I../../net/third_party/nss/ssl
> -I../../third_party/skia/src/core -I../../third_party/skia/include/core
> -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf
> -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy
> -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe
> -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils
> -I../../skia/ext -I../../third_party/re2 -I../../third_party/zlib
> -I../../third_party/WebKit -I../../third_party/icu/source/i18n
> -I../../third_party/icu/source/common -Igen/ui/resources -Igen/protoc_out
> -I../../third_party/protobuf -I../../third_party/protobuf/src
> -Igen/content/app/resources/ -Igen/webkit
> -I../../third_party/leveldatabase/src/include
> -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase
> -I../../third_party/WebKit -I../../third_party/npapi
> -I../../third_party/npapi/bindings -I../../v8/include
-I../../third_party/libpng
> -I../../third_party/libwebp -I../../third_party/ots/include
> -I../../third_party/qcms/src -I../../third_party/iccjpeg
> -I../../third_party/libjpeg_turbo -Igen/content/browser/tracing
> -I../../third_party/libyuv/include -I../../third_party/libyuv
> -I../../third_party/webrtc/overrides -I../../third_party/libjingle/overrides
> -I../../third_party/libjingle/source -I../../testing/gtest/include
> -I../../third_party -I../../third_party/speex/include -fstack-protector
> --param=ssp-buffer-size=4 -Werror -pthread -fno-strict-aliasing -Wall
> -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden
-pipe
> -fPIC -Wno-reserved-user-defined-literal -Xclang -load -Xclang
>
/b/build/slave/GPU_Linux_Builder/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so
> -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics
>
-B/b/build/slave/GPU_Linux_Builder/build/src/third_party/binutils/Linux_x64/Release/bin
> -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration
> -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing
> -Wno-deprecated-register -Wno-unused-local-typedef -Wexit-time-destructors
> -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include
> -I/usr/include/nss -I/usr/include/nspr -Wno-header-guard -pthread
> -I/usr/include/pango-1.0 -I/usr/include/cairo -I/usr/include/glib-2.0
> -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1
> -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/dbus-1.0
> -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -m64 -march=x86-64 -O2 -fno-ident
> -fdata-sections -ffunction-sections -funwind-tables -fno-exceptions -fno-rtti
> -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare
-std=gnu++11 
> -c gen/content/browser/devtools/protocol/devtools_protocol_handler_impl.cc -o
>
obj/content/gen/content/browser/devtools/protocol/content_browser.devtools_protocol_handler_impl.o
> gen/content/browser/devtools/protocol/devtools_protocol_handler_impl.cc:951:7:
> error: no viable conversion from 'std::string' (aka 'basic_string<char>') to
> 'const std::string *' (aka 'const basic_string<char> *')
>       in_categories,
>       ^~~~~~~~~~~~~
> ../../content/browser/devtools/protocol/tracing_handler.h:40:26: note: passing
> argument to parameter 'categories' here
>       const std::string* categories,
>                          ^
> 1 error generated.
> ninja: build stopped: subcommand failed..

Note: I think this actually broke because of the roll back here
https://codereview.chromium.org/675533002, which caused
https://codereview.chromium.org/665123008 to be reverted from chrome (but we
needed the roll back).  I think this can be resubmitted once we roll forward for
real.

[dgozman, 2014-10-23 10:07:44]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-10-23 10:08:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/635733003/130001

[commit-bot: I haz the power, 2014-10-23 10:09:45]

Committed patchset #6 (id:130001)

[commit-bot: I haz the power, 2014-10-23 10:11:59]

Patchset 6 (id:??) landed as
https://crrev.com/1b3d5f311e8f4fd6ff4352fec7e0dee303f2a322
Cr-Commit-Position: refs/heads/master@{#300861}