Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 635733002: Further improve hashing of pointers and integers. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer
Modified:
6 years, 2 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Further improve hashing of pointers and integers. Also make sure that the appropriate functions are inlined properly (using V8_INLINE instead of inline to enforce it even with GCC), and improve the HashIsOkish unittest. TEST=unittests R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24427

Patch Set 1 #

Patch Set 2 : Comments #

Patch Set 3 : Cleanup #

Patch Set 4 : Also fix HashIsOkish test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -52 lines) Patch
M src/base/functional.h View 1 2 4 chunks +23 lines, -15 lines 0 comments Download
M src/base/functional.cc View 1 2 3 chunks +42 lines, -33 lines 0 comments Download
M test/unittests/base/functional-unittest.cc View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Benedikt Meurer
PTAL
6 years, 2 months ago (2014-10-07 07:19:52 UTC) #2
Sven Panne
lgtm
6 years, 2 months ago (2014-10-07 07:23:18 UTC) #3
Benedikt Meurer
6 years, 2 months ago (2014-10-07 07:39:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as 24427 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698