Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 63573006: [NaCl SDK] nacl_io: Auto-bind UDP socket on first sendto(). (Closed)

Created:
7 years, 1 month ago by binji
Modified:
7 years, 1 month ago
Reviewers:
Sam Clegg
CC:
chromium-reviews, Sam Clegg
Visibility:
Public.

Description

[NaCl SDK] nacl_io: Auto-bind UDP socket on first sendto(). BUG=318983 R=sbc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235833

Patch Set 1 #

Total comments: 2

Patch Set 2 : getsockname stuff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -6 lines) Patch
M native_client_sdk/src/libraries/nacl_io/mount_node_socket.cc View 1 1 chunk +6 lines, -3 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/mount_node_udp.cc View 2 chunks +19 lines, -3 lines 0 comments Download
M native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc View 1 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
binji
7 years, 1 month ago (2013-11-18 02:54:14 UTC) #1
Sam Clegg
lgtm https://codereview.chromium.org/63573006/diff/1/native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc File native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc (right): https://codereview.chromium.org/63573006/diff/1/native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc#newcode255 native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc:255: // at the time of the first send. ...
7 years, 1 month ago (2013-11-18 17:10:41 UTC) #2
binji
https://codereview.chromium.org/63573006/diff/1/native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc File native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc (right): https://codereview.chromium.org/63573006/diff/1/native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc#newcode255 native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc:255: // at the time of the first send. On ...
7 years, 1 month ago (2013-11-18 20:54:17 UTC) #3
binji
7 years, 1 month ago (2013-11-18 22:43:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r235833 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698