Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 63573004: Fix implementation of compare-minus-zero-and-branch on ia32 and x64. (Closed)

Created:
7 years, 1 month ago by Yang
Modified:
7 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fix implementation of compare-minus-zero-and-branch on ia32 and x64. R=jkummerow@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=17657

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
7 years, 1 month ago (2013-11-12 15:08:26 UTC) #1
Jakob Kummerow
LGTM with comment. https://codereview.chromium.org/63573004/diff/1/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): https://codereview.chromium.org/63573004/diff/1/src/x64/lithium-codegen-x64.cc#newcode2253 src/x64/lithium-codegen-x64.cc:2253: __ int3(); Might wanna remove this ...
7 years, 1 month ago (2013-11-12 15:10:02 UTC) #2
Yang
7 years, 1 month ago (2013-11-12 15:11:13 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r17657 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698