Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 635713002: Replace OVERRIDE and FINAL with override and final in content/browser/loader (Closed)

Created:
6 years, 2 months ago by Anand Ratn (left samsung)
Modified:
6 years, 2 months ago
Reviewers:
nasko
CC:
chromium-reviews, mkwst+moarreviews-ipc_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replace OVERRIDE and FINAL with override and final in content/browser/loader BUG=417463 Committed: https://crrev.com/2c5e14559d56c73a8dd07d5156e97fbe2161cfef Cr-Commit-Position: refs/heads/master@{#298489}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -190 lines) Patch
M content/browser/loader/async_resource_handler.h View 1 chunk +10 lines, -10 lines 0 comments Download
M content/browser/loader/buffered_resource_handler.h View 1 chunk +9 lines, -9 lines 0 comments Download
M content/browser/loader/certificate_resource_handler.h View 1 chunk +9 lines, -9 lines 0 comments Download
M content/browser/loader/cross_site_resource_handler.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/loader/detachable_resource_handler.h View 1 chunk +14 lines, -14 lines 0 comments Download
M content/browser/loader/layered_resource_handler.h View 1 chunk +10 lines, -10 lines 0 comments Download
M content/browser/loader/power_save_block_resource_throttle.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/loader/redirect_to_file_resource_handler.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.h View 3 chunks +12 lines, -12 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_unittest.cc View 16 chunks +19 lines, -19 lines 0 comments Download
M content/browser/loader/resource_loader.h View 1 chunk +13 lines, -13 lines 0 comments Download
M content/browser/loader/resource_loader_unittest.cc View 10 chunks +20 lines, -20 lines 0 comments Download
M content/browser/loader/resource_message_filter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/loader/resource_request_info_impl.h View 1 chunk +19 lines, -19 lines 0 comments Download
M content/browser/loader/resource_scheduler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/loader/resource_scheduler_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_scheduler_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M content/browser/loader/stream_resource_handler.h View 1 chunk +11 lines, -11 lines 0 comments Download
M content/browser/loader/sync_resource_handler.h View 1 chunk +9 lines, -9 lines 0 comments Download
M content/browser/loader/throttling_resource_handler.h View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Anand Ratn (left samsung)
PTAL
6 years, 2 months ago (2014-10-07 03:37:20 UTC) #2
nasko
lgtm
6 years, 2 months ago (2014-10-07 14:10:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/635713002/1
6 years, 2 months ago (2014-10-07 14:40:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as da062cf07fe778b8860c2b42218e66aee37150e9
6 years, 2 months ago (2014-10-07 15:50:15 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 15:51:28 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2c5e14559d56c73a8dd07d5156e97fbe2161cfef
Cr-Commit-Position: refs/heads/master@{#298489}

Powered by Google App Engine
This is Rietveld 408576698