Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2693)

Unified Diff: tests/lib/mirrors/parameter_test.dart

Issue 63563003: - Reverting mirror changes. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/lib/mirrors/parameter_metadata_test.dart ('k') | tests/lib/mirrors/private_symbol_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/mirrors/parameter_test.dart
===================================================================
--- tests/lib/mirrors/parameter_test.dart (revision 30026)
+++ tests/lib/mirrors/parameter_test.dart (working copy)
@@ -45,7 +45,10 @@
main() {
ClassMirror cm = reflectClass(B);
- Map<Symbol, MethodMirror> constructors = cm.constructors;
+ var constructors = new Map<Symbol, MethodMirror>();
+ cm.declarations.forEach((k, v) {
+ if (v is MethodMirror && v.isConstructor) constructors[k] = v;
+ });
List<Symbol> constructorKeys =
[#B, #B.bar, #B.baz, #B.foo, #B.quux, #B.qux, #B.corge];
@@ -124,31 +127,31 @@
expect('Class(s(B) in s(test.parameter_test), top-level)',
corgeConstructor.returnType);
- MethodMirror xGetter = cm.getters[#x];
+ MethodMirror xGetter = cm.declarations[#x];
expect('Method(s(x) in s(B), getter)', xGetter);
expect('[]', xGetter.parameters);
- MethodMirror xSetter = cm.setters[const Symbol('x=')];
+ MethodMirror xSetter = cm.declarations[const Symbol('x=')];
expect('Method(s(x=) in s(B), setter)', xSetter);
expect('[Parameter(s(value) in s(x=), final,'
' type = Type(s(dynamic), top-level))]',
xSetter.parameters);
- MethodMirror grault = cm.members[#grault];
+ MethodMirror grault = cm.declarations[#grault];
expect('Method(s(grault) in s(B))', grault);
expect('[Parameter(s(x) in s(grault), optional,'
' type = Class(s(int) in s(dart.core), top-level))]',
grault.parameters);
expect('Instance(value = <null>)', grault.parameters[0].defaultValue);
- MethodMirror garply = cm.members[#garply];
+ MethodMirror garply = cm.declarations[#garply];
expect('Method(s(garply) in s(B))', garply);
expect('[Parameter(s(y) in s(garply), optional, named,'
' type = Class(s(int) in s(dart.core), top-level))]',
garply.parameters);
expect('Instance(value = <null>)', garply.parameters[0].defaultValue);
- MethodMirror waldo = cm.members[#waldo];
+ MethodMirror waldo = cm.declarations[#waldo];
expect('Method(s(waldo) in s(B))', waldo);
expect('[Parameter(s(z) in s(waldo),'
' type = Class(s(int) in s(dart.core), top-level))]',
@@ -157,7 +160,7 @@
cm = reflectClass(C);
- MethodMirror fooInC = cm.members[#foo];
+ MethodMirror fooInC = cm.declarations[#foo];
expect('Method(s(foo) in s(C))', fooInC);
expect('[Parameter(s(a) in s(foo),'
' type = Class(s(int) in s(dart.core), top-level)), '
@@ -166,7 +169,7 @@
' upperBound = Class(s(int) in s(dart.core), top-level)))]',
fooInC.parameters);
- MethodMirror barInC = cm.members[#bar];
+ MethodMirror barInC = cm.declarations[#bar];
expect('Method(s(bar) in s(C))', barInC);
expect('[Parameter(s(a) in s(bar),'
' type = TypeVariable(s(S) in s(C),'
« no previous file with comments | « tests/lib/mirrors/parameter_metadata_test.dart ('k') | tests/lib/mirrors/private_symbol_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698