Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: pkg/unittest/lib/mirror_matchers.dart

Issue 63563003: - Reverting mirror changes. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/unittest/lib/mirror_matchers.dart
===================================================================
--- pkg/unittest/lib/mirror_matchers.dart (revision 30026)
+++ pkg/unittest/lib/mirror_matchers.dart (working copy)
@@ -49,7 +49,13 @@
var mirror = reflect(item);
var classMirror = mirror.type;
var symbol = new Symbol(_name);
- if (!classMirror.getters.containsKey(symbol)) {
+ bool hasGetter(classMirror, getterName) {
+ var candidate = classMirror.declarations[getterName];
+ return candidate != null &&
+ candidate is MethodMirror &&
+ candidate.isGetter;
+ }
+ if (!hasGetter(classMirror, symbol)) {
addStateInfo(matchState, {'reason': 'has no property named "$_name"'});
return false;
}
« no previous file with comments | « pkg/serialization/lib/src/serialization_rule.dart ('k') | runtime/tests/vm/dart/mirrored_compilation_error_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698