Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Side by Side Diff: chrome/utility/web_resource_unpacker.h

Issue 635623003: Cleanup: Better constify some strings in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix mac Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/utility/importer/safari_importer.mm ('k') | chrome/utility/web_resource_unpacker.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This class is called by the WebResourceService in a sandboxed process 5 // This class is called by the WebResourceService in a sandboxed process
6 // to unpack data retrieved from a web resource feed. Right now, it 6 // to unpack data retrieved from a web resource feed. Right now, it
7 // takes a string of data in JSON format, parses it, and hands it back 7 // takes a string of data in JSON format, parses it, and hands it back
8 // to the WebResourceService as a list of items. In the future 8 // to the WebResourceService as a list of items. In the future
9 // it will be set up to unpack and verify image data in addition to 9 // it will be set up to unpack and verify image data in addition to
10 // just parsing a JSON feed. 10 // just parsing a JSON feed.
11 11
12 #ifndef CHROME_UTILITY_WEB_RESOURCE_UNPACKER_H_ 12 #ifndef CHROME_UTILITY_WEB_RESOURCE_UNPACKER_H_
13 #define CHROME_UTILITY_WEB_RESOURCE_UNPACKER_H_ 13 #define CHROME_UTILITY_WEB_RESOURCE_UNPACKER_H_
14 14
15 #include <string> 15 #include <string>
16 16
17 #include "base/basictypes.h" 17 #include "base/basictypes.h"
18 #include "base/memory/scoped_ptr.h" 18 #include "base/memory/scoped_ptr.h"
19 19
20 namespace base { 20 namespace base {
21 class DictionaryValue; 21 class DictionaryValue;
22 } 22 }
23 23
24 class WebResourceUnpacker { 24 class WebResourceUnpacker {
25 public: 25 public:
26 static const char* kInvalidDataTypeError; 26 static const char kInvalidDataTypeError[];
27 static const char* kUnexpectedJSONFormatError; 27 static const char kUnexpectedJSONFormatError[];
28 28
29 explicit WebResourceUnpacker(const std::string &resource_data); 29 explicit WebResourceUnpacker(const std::string &resource_data);
30 ~WebResourceUnpacker(); 30 ~WebResourceUnpacker();
31 31
32 // This does the actual parsing. In case of an error, error_message_ 32 // This does the actual parsing. In case of an error, error_message_
33 // is set to an appropriate value. 33 // is set to an appropriate value.
34 bool Run(); 34 bool Run();
35 35
36 // Returns the last error message set by Run(). 36 // Returns the last error message set by Run().
37 const std::string& error_message() { return error_message_; } 37 const std::string& error_message() { return error_message_; }
(...skipping 10 matching lines...) Expand all
48 // Holds the result of JSON parsing of resource_data_. 48 // Holds the result of JSON parsing of resource_data_.
49 scoped_ptr<base::DictionaryValue> parsed_json_; 49 scoped_ptr<base::DictionaryValue> parsed_json_;
50 50
51 // Holds the last error message produced by Run(). 51 // Holds the last error message produced by Run().
52 std::string error_message_; 52 std::string error_message_;
53 53
54 DISALLOW_COPY_AND_ASSIGN(WebResourceUnpacker); 54 DISALLOW_COPY_AND_ASSIGN(WebResourceUnpacker);
55 }; 55 };
56 56
57 #endif // CHROME_UTILITY_WEB_RESOURCE_UNPACKER_H_ 57 #endif // CHROME_UTILITY_WEB_RESOURCE_UNPACKER_H_
OLDNEW
« no previous file with comments | « chrome/utility/importer/safari_importer.mm ('k') | chrome/utility/web_resource_unpacker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698