Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1235)

Unified Diff: content/renderer/pepper/v8_var_converter.cc

Issue 635593004: PPAPI: Make V8VarConverter longer-lived (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/pepper/v8_var_converter.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/pepper/v8_var_converter.cc
diff --git a/content/renderer/pepper/v8_var_converter.cc b/content/renderer/pepper/v8_var_converter.cc
index 3c3503046a9ab3dbc2dfba51a9fcfbd7e2add162..bb0f0dd45bf9049dac5cc26283e803f823483a20 100644
--- a/content/renderer/pepper/v8_var_converter.cc
+++ b/content/renderer/pepper/v8_var_converter.cc
@@ -285,28 +285,17 @@ bool CanHaveChildren(PP_Var var) {
} // namespace
-V8VarConverter::V8VarConverter(PP_Instance instance)
- : instance_(instance),
- object_vars_allowed_(kDisallowObjectVars),
- message_loop_proxy_(base::MessageLoopProxy::current()) {
- resource_converter_.reset(new ResourceConverterImpl(
- instance, RendererPpapiHost::GetForPPInstance(instance)));
-}
-
V8VarConverter::V8VarConverter(PP_Instance instance,
AllowObjectVars object_vars_allowed)
: instance_(instance),
- object_vars_allowed_(object_vars_allowed),
- message_loop_proxy_(base::MessageLoopProxy::current()) {
- resource_converter_.reset(new ResourceConverterImpl(
- instance, RendererPpapiHost::GetForPPInstance(instance)));
+ object_vars_allowed_(object_vars_allowed) {
+ resource_converter_.reset(new ResourceConverterImpl(instance));
}
V8VarConverter::V8VarConverter(PP_Instance instance,
scoped_ptr<ResourceConverter> resource_converter)
: instance_(instance),
object_vars_allowed_(kDisallowObjectVars),
- message_loop_proxy_(base::MessageLoopProxy::current()),
resource_converter_(resource_converter.release()) {}
V8VarConverter::~V8VarConverter() {}
« no previous file with comments | « content/renderer/pepper/v8_var_converter.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698