Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Unified Diff: chrome/browser/extensions/extension_service_unittest.cc

Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix cros, really Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service_unittest.cc
diff --git a/chrome/browser/extensions/extension_service_unittest.cc b/chrome/browser/extensions/extension_service_unittest.cc
index 3e8614e81a004ed7608f70d19d1f7e8242f837a0..d1c0db9a383ba6a092d467231d5c285ebd016eb5 100644
--- a/chrome/browser/extensions/extension_service_unittest.cc
+++ b/chrome/browser/extensions/extension_service_unittest.cc
@@ -1294,7 +1294,7 @@ TEST_F(ExtensionServiceTest, LoadAllExtensionsFromDirectorySuccess) {
extensions::ContentScriptsInfo::GetContentScripts(
loaded_[index].get()).size());
EXPECT_EQ(Manifest::INTERNAL, loaded_[index]->location());
-};
+}
// Test loading bad extensions from the profile directory.
TEST_F(ExtensionServiceTest, LoadAllExtensionsFromDirectoryFail) {
@@ -1330,7 +1330,7 @@ TEST_F(ExtensionServiceTest, LoadAllExtensionsFromDirectoryFail) {
std::string("Could not load extension from '*'. ") +
extensions::manifest_errors::kManifestUnreadable)) <<
base::UTF16ToUTF8(GetErrors()[3]);
-};
+}
// Test various cases for delayed install because of missing imports.
TEST_F(ExtensionServiceTest, PendingImports) {
@@ -4033,7 +4033,7 @@ TEST_F(ExtensionServiceTest, ReloadExtensions) {
base::FilePath path = data_dir().AppendASCII("good.crx");
InstallCRX(path, INSTALL_NEW,
Extension::FROM_WEBSTORE | Extension::WAS_INSTALLED_BY_DEFAULT);
- const char* extension_id = good_crx;
+ const char* const extension_id = good_crx;
service()->DisableExtension(extension_id, Extension::DISABLE_USER_ACTION);
EXPECT_EQ(0u, registry()->enabled_extensions().size());
@@ -4073,7 +4073,7 @@ TEST_F(ExtensionServiceTest, ReloadExtension) {
InitializeProcessManager();
// Simple extension that should install without error.
- const char* extension_id = "behllobkkfkfnphdnhnkndlbkcpglgmj";
+ const char extension_id[] = "behllobkkfkfnphdnhnkndlbkcpglgmj";
base::FilePath ext = data_dir()
.AppendASCII("good")
.AppendASCII("Extensions")
@@ -6252,7 +6252,7 @@ TEST_F(ExtensionServiceTest,
EXPECT_FALSE(
registry()->GenerateInstalledExtensionsSet()->Contains(extension_ids[1]));
}
-#endif // defined(ENABLE_MANAGED_USERS)
+#endif // defined(ENABLE_MANAGED_USERS)
TEST_F(ExtensionServiceTest, InstallPriorityExternalUpdateUrl) {
InitializeEmptyExtensionService();

Powered by Google App Engine
This is Rietveld 408576698