Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1059)

Unified Diff: chrome/browser/extensions/error_console/error_console_browsertest.cc

Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix cros, really Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/error_console/error_console_browsertest.cc
diff --git a/chrome/browser/extensions/error_console/error_console_browsertest.cc b/chrome/browser/extensions/error_console/error_console_browsertest.cc
index e7857a2eb4b83e384432e5528bf545e586515657..400b538d751921ac28850c5df368a039dad294d8 100644
--- a/chrome/browser/extensions/error_console/error_console_browsertest.cc
+++ b/chrome/browser/extensions/error_console/error_console_browsertest.cc
@@ -35,7 +35,7 @@ namespace {
const char kTestingPage[] = "/extensions/test_file.html";
const char kAnonymousFunction[] = "(anonymous function)";
-const char* kBackgroundPageName =
+const char* const kBackgroundPageName =
extensions::kGeneratedBackgroundPageFilename;
const int kNoFlags = 0;
@@ -274,6 +274,7 @@ class ErrorConsoleBrowserTest : public ExtensionBrowserTest {
}
ErrorConsole* error_console() { return error_console_; }
+
private:
// The URL used in testing for simple page navigations.
GURL test_url_;
@@ -391,7 +392,7 @@ IN_PROC_BROWSER_TEST_F(ErrorConsoleBrowserTest,
script_url,
"logHelloWorld", // function name
6u, // line number
- 11u /* column number */ );
+ 11u /* column number */);
CheckStackFrame(stack_trace1[1],
script_url,

Powered by Google App Engine
This is Rietveld 408576698