chrome/browser/extensions/crx_installer.cc - Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/crx_installer.cc

Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix cros, really Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/activity_log/hashed_ad_network_database.h ('K') | « chrome/browser/extensions/content_script_apitest.cc ('k') | chrome/browser/extensions/default_apps.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/crx_installer.cc

diff --git a/chrome/browser/extensions/crx_installer.cc b/chrome/browser/extensions/crx_installer.cc

index 9402445f083154d4af5b31ce3454ddd0f8558e32..fda5153f610aac6dd5cf242871d0aec8a4e2ec97 100644

--- a/chrome/browser/extensions/crx_installer.cc

+++ b/chrome/browser/extensions/crx_installer.cc

@@ -330,7 +330,7 @@ CrxInstallerError CrxInstaller::AllowInstall(const Extension* extension) {

if (install_cause_ == extension_misc::INSTALL_CAUSE_USER_DOWNLOAD) {

if (FeatureSwitch::easy_off_store_install()->IsEnabled()) {

- const char* kHistogramName = "Extensions.OffStoreInstallDecisionEasy";

+ const char kHistogramName[] = "Extensions.OffStoreInstallDecisionEasy";

if (is_gallery_install()) {

UMA_HISTOGRAM_ENUMERATION(kHistogramName, OnStoreInstall,

NumOffStoreInstallDecision);

@@ -339,7 +339,7 @@ CrxInstallerError CrxInstaller::AllowInstall(const Extension* extension) {

NumOffStoreInstallDecision);

}

} else {

- const char* kHistogramName = "Extensions.OffStoreInstallDecisionHard";

+ const char kHistogramName[] = "Extensions.OffStoreInstallDecisionHard";

if (is_gallery_install()) {

UMA_HISTOGRAM_ENUMERATION(kHistogramName, OnStoreInstall,

NumOffStoreInstallDecision);