chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc - Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc

Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix cros, really Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/activity_log/hashed_ad_network_database.h ('K') | « chrome/browser/extensions/api/web_request/web_request_api_unittest.cc ('k') | chrome/browser/extensions/chrome_app_sorting.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc

diff --git a/chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc b/chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc

index 602ceb6c2788ed50150ef72aa798ebb25cfa3858..c464465a4789b3589685d0354bc2b751e96a5891 100644

--- a/chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc

+++ b/chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc

@@ -77,7 +77,7 @@ void ExtensionWebRequestHelpersTestWithThreadsTest::SetUp() {

TEST_F(ExtensionWebRequestHelpersTestWithThreadsTest, TestHideRequestForURL) {

net::TestURLRequestContext context;

- const char* sensitive_urls[] = {

+ const char* const sensitive_urls[] = {

"http://clients2.google.com",

"http://clients22.google.com",

"https://clients2.google.com",

@@ -92,7 +92,7 @@ TEST_F(ExtensionWebRequestHelpersTestWithThreadsTest, TestHideRequestForURL) {

"https://chrome.google.com/webstore/"

"inlineinstall/detail/kcnhkahnjcbndmmehfkdnkjomaanaooo"

};

- const char* non_sensitive_urls[] = {

+ const char* const non_sensitive_urls[] = {

"http://www.google.com/"

};

const int kSigninProcessId = 99;