Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2412)

Unified Diff: chrome/browser/extensions/api/management/management_browsertest.cc

Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix cros, really Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/management/management_browsertest.cc
diff --git a/chrome/browser/extensions/api/management/management_browsertest.cc b/chrome/browser/extensions/api/management/management_browsertest.cc
index 30f7a134a8d84072aae029d90e73cfe655fee3fd..ecf9896291dfa9d4ddda931a8e7153c5901a709e 100644
--- a/chrome/browser/extensions/api/management/management_browsertest.cc
+++ b/chrome/browser/extensions/api/management/management_browsertest.cc
@@ -439,7 +439,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementTest,
IN_PROC_BROWSER_TEST_F(ExtensionManagementTest, ExternalUrlUpdate) {
ExtensionService* service = extensions::ExtensionSystem::Get(
browser()->profile())->extension_service();
- const char* kExtensionId = "ogjcoiohnmldgjemafoockdghcjciccf";
+ const char kExtensionId[] = "ogjcoiohnmldgjemafoockdghcjciccf";
extensions::ExtensionUpdater::CheckParams params;
base::FilePath basedir = test_data_dir_.AppendASCII("autoupdate");
@@ -524,7 +524,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementTest, ExternalUrlUpdate) {
namespace {
-const char* kForceInstallNotEmptyHelp =
+const char kForceInstallNotEmptyHelp[] =
"A policy may already be controlling the list of force-installed "
"extensions. Please remove all policy settings from your computer "
"before running tests. E.g. from /etc/chromium/policies Linux or "
@@ -536,7 +536,7 @@ const char* kForceInstallNotEmptyHelp =
IN_PROC_BROWSER_TEST_F(ExtensionManagementTest, ExternalPolicyRefresh) {
ExtensionService* service = extensions::ExtensionSystem::Get(
browser()->profile())->extension_service();
- const char* kExtensionId = "ogjcoiohnmldgjemafoockdghcjciccf";
+ const char kExtensionId[] = "ogjcoiohnmldgjemafoockdghcjciccf";
base::FilePath basedir = test_data_dir_.AppendASCII("autoupdate");
@@ -617,7 +617,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementTest,
ExtensionService* service = extensions::ExtensionSystem::Get(
browser()->profile())->extension_service();
ExtensionRegistry* registry = ExtensionRegistry::Get(browser()->profile());
- const char* kExtensionId = "ogjcoiohnmldgjemafoockdghcjciccf";
+ const char kExtensionId[] = "ogjcoiohnmldgjemafoockdghcjciccf";
extensions::ExtensionUpdater::CheckParams params;
service->updater()->set_default_check_params(params);
const size_t size_before = registry->enabled_extensions().size();

Powered by Google App Engine
This is Rietveld 408576698