chrome/browser/extensions/api/content_settings/content_settings_apitest.cc - Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/content_settings/content_settings_apitest.cc

Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix cros, really Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/activity_log/hashed_ad_network_database.h ('K') | « chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.cc ('k') | chrome/browser/extensions/api/declarative_content/request_content_script_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/content_settings/content_settings_apitest.cc

diff --git a/chrome/browser/extensions/api/content_settings/content_settings_apitest.cc b/chrome/browser/extensions/api/content_settings/content_settings_apitest.cc

index f457a3a74993f7a69e2e6d76f6980dd119fbb5ab..1e7121a59a248d06917f0f64add3724286e64ccc 100644

--- a/chrome/browser/extensions/api/content_settings/content_settings_apitest.cc

+++ b/chrome/browser/extensions/api/content_settings/content_settings_apitest.cc

@@ -215,8 +215,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionContentSettingsApiTest,

FILE_PATH_LITERAL("/plugins/foo.plugin");

base::FilePath::CharType kBarPath[] =

FILE_PATH_LITERAL("/plugins/bar.plugin");

- const char* kFooName = "Foo Plugin";

- const char* kBarName = "Bar Plugin";

+ const char kFooName[] = "Foo Plugin";

+ const char kBarName[] = "Bar Plugin";

content::PluginService::GetInstance()->RegisterInternalPlugin(

content::WebPluginInfo(base::ASCIIToUTF16(kFooName),