Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2442)

Unified Diff: chrome/browser/chromeos/policy/device_local_account_browsertest.cc

Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase, nit Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/device_local_account_browsertest.cc
diff --git a/chrome/browser/chromeos/policy/device_local_account_browsertest.cc b/chrome/browser/chromeos/policy/device_local_account_browsertest.cc
index 5922fee18dd76ad0adf38f0b9106bfeeae6ed01e..0a2cd604f15691afefe746a1ab8bed0c8f849e90 100644
--- a/chrome/browser/chromeos/policy/device_local_account_browsertest.cc
+++ b/chrome/browser/chromeos/policy/device_local_account_browsertest.cc
@@ -152,7 +152,7 @@ const char kAccountId1[] = "dla1@example.com";
const char kAccountId2[] = "dla2@example.com";
const char kDisplayName1[] = "display name 1";
const char kDisplayName2[] = "display name 2";
-const char* kStartupURLs[] = {
+const char* const kStartupURLs[] = {
"chrome://policy",
"chrome://about",
};
@@ -179,19 +179,19 @@ const char kPackagedAppCRXPath[] = "extensions/platform_apps/app_window_2.crx";
const char kExternalData[] = "External data";
const char kExternalDataURL[] = "http://localhost/external_data";
-const char* kSingleRecommendedLocale[] = {
+const char* const kSingleRecommendedLocale[] = {
"el",
};
-const char* kRecommendedLocales1[] = {
+const char* const kRecommendedLocales1[] = {
"pl",
"et",
"en-US",
};
-const char* kRecommendedLocales2[] = {
+const char* const kRecommendedLocales2[] = {
"fr",
"nl",
};
-const char* kInvalidRecommendedLocale[] = {
+const char* const kInvalidRecommendedLocale[] = {
"xx",
};
const char kPublicSessionLocale[] = "de";
@@ -563,7 +563,7 @@ class DeviceLocalAccountTest : public DevicePolicyCrosBrowserTest,
kAccountId1, device_local_account_policy_.GetBlob());
}
- void SetRecommendedLocales(const char* recommended_locales[],
+ void SetRecommendedLocales(const char* const recommended_locales[],
size_t array_size) {
em::StringListPolicyProto* session_locales_proto =
device_local_account_policy_.payload().mutable_sessionlocales();

Powered by Google App Engine
This is Rietveld 408576698