Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}.

chrome/browser/extensions/api/alarms/alarms_api_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file tests the chrome.alarms extension API.
 
 #include "base/test/simple_test_clock.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/api/alarms/alarm_manager.h"
 #include "chrome/browser/extensions/api/alarms/alarms_api.h"
@@ skipping 71 matching lines @@
         return list;
       }
       EXPECT_TRUE(JsAlarm::Populate(*alarm_value, alarm.get()));
       list.push_back(alarm);
     }
     return list;
   }
 
   // Creates up to 3 alarms using the extension API.
   void CreateAlarms(size_t num_alarms) {
-    CHECK(num_alarms <= 3);
+    CHECK_LE(num_alarms, 3U);
 
-    const char* kCreateArgs[] = {
+    const char* const kCreateArgs[] = {
       "[null, {\"periodInMinutes\": 0.001}]",
       "[\"7\", {\"periodInMinutes\": 7}]",
       "[\"0\", {\"delayInMinutes\": 0}]",
     };
     for (size_t i = 0; i < num_alarms; ++i) {
       scoped_ptr<base::DictionaryValue> result(RunFunctionAndReturnDictionary(
           new AlarmsCreateFunction(test_clock_), kCreateArgs[i]));
       EXPECT_FALSE(result.get());
     }
   }
@@ skipping 348 matching lines @@
 }
 
 class ExtensionAlarmsSchedulingTest : public ExtensionAlarmsTest {
   void GetAlarmCallback(Alarm* alarm) {
     CHECK(alarm);
     const base::Time scheduled_time =
         base::Time::FromJsTime(alarm->js_alarm->scheduled_time);
     EXPECT_EQ(scheduled_time, alarm_manager_->next_poll_time_);
   }
 
-  static void RemoveAlarmCallback (bool success) { EXPECT_TRUE(success); }
-  static void RemoveAllAlarmsCallback () {}
+  static void RemoveAlarmCallback(bool success) { EXPECT_TRUE(success); }
+  static void RemoveAllAlarmsCallback() {}
+
  public:
   // Get the time that the alarm named is scheduled to run.
   void VerifyScheduledTime(const std::string& alarm_name) {
     alarm_manager_->GetAlarm(extension()->id(), alarm_name, base::Bind(
         &ExtensionAlarmsSchedulingTest::GetAlarmCallback,
         base::Unretained(this)));
   }
 
   void RemoveAlarm(const std::string& name) {
     alarm_manager_->RemoveAlarm(
         extension()->id(),
         name,
         base::Bind(&ExtensionAlarmsSchedulingTest::RemoveAlarmCallback));
   }
 
-  void RemoveAllAlarms () {
+  void RemoveAllAlarms() {
     alarm_manager_->RemoveAllAlarms(extension()->id(), base::Bind(
         &ExtensionAlarmsSchedulingTest::RemoveAllAlarmsCallback));
   }
 };
 
 TEST_F(ExtensionAlarmsSchedulingTest, PollScheduling) {
   {
     CreateAlarm("[\"a\", {\"periodInMinutes\": 6}]");
     CreateAlarm("[\"bb\", {\"periodInMinutes\": 8}]");
     VerifyScheduledTime("a");
@@ skipping 166 matching lines @@
 
   // The next poll should be the first poll that hasn't happened and is in-line
   // with the original scheduling.
   // Last poll was at 380 seconds; next poll should be at 480 seconds.
   EXPECT_DOUBLE_EQ((alarm_manager_->last_poll_time_ +
                        base::TimeDelta::FromSeconds(100)).ToJsTime(),
                    alarm_manager_->next_poll_time_.ToJsTime());
 }
 
 }  // namespace extensions