Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}.

chrome/browser/extensions/activity_log/uma_policy_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/metrics/histogram.h"
 #include "base/strings/stringprintf.h"
 #include "chrome/browser/extensions/activity_log/uma_policy.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/extension_browsertest.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/test_extension_dir.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "extensions/common/manifest_constants.h"
 #include "net/dns/mock_host_resolver.h"
 
 using extensions::UmaPolicy;
 
-const char* kGooglePrefix = "ExtensionActivity.Google";
-const char* kNonGooglePrefix = "ExtensionActivity";
+const char kGooglePrefix[] = "ExtensionActivity.Google";
+const char kNonGooglePrefix[] = "ExtensionActivity";
 
 // These tests need to ensure that all of the extension JavaScript completes
 // before the histograms are checked. To accomplish this, the test relies on
 // some JavaScript in chrome/test/data/extensions/api_test/uma_policy/:
 // * When the test navigates to opener.com, opener.js will use window.open() to
 //   pop open a new window with the appropriate URL for the test case. This
 //   ensures that the testing framework never reuses a window that's still
 //   running a previous test case.
 // * The test extension code in content_script.js tells background.js when it's
 //   done. When it's finished, background.js closes the blocker.com window. So
@@ skipping 171 matching lines @@
 
 // This runs with multiple extensions installed.
 IN_PROC_BROWSER_TEST_F(ActivityLogUmaPolicyTest, DISABLED_MultipleExtensions) {
   host_resolver()->AddRule("*", "127.0.0.1");
   StartEmbeddedTestServer();
 
   const extensions::Extension* ext =
       LoadExtension(test_data_dir_.AppendASCII("uma_policy"));
   ASSERT_TRUE(ext);
 
-  const char* script2 =
+  const char script2[] =
       "document.createElement('script');"
       "document.createElement('iframe');"
       "document.createElement('div');"
       "document.createElement('embed');"
       "document.createElement('object');";
 
-  const char* manifest =
+  const char manifest[] =
       "{"
       "  \"name\": \"Activity Log UMA Policy Test Extension\","
       "  \"version\": \"0.%s\","
       "  \"description\": \"Testing the histogramming\","
       "  \"content_scripts\": ["
       "      {"
       "        \"matches\": "
       "            [\"http://www.google.com/*\","
       "             \"http://www.cnn.com/*\"],"
       "        \"js\": [\"content_script.js\"]"
@@ skipping 11 matching lines @@
         browser(), GURL("http://www.opener.com/#google"), NEW_WINDOW,
         ui_test_utils::BROWSER_TEST_NONE);
   ui_test_utils::NavigateToURLBlockUntilNavigationsComplete(
       browser(), GURL("http://www.blocker.com"), 2);
   ui_test_utils::NavigateToURLWithDisposition(
         browser(), GURL("http://www.opener.com/#cnn?q=b"), NEW_WINDOW,
         ui_test_utils::BROWSER_TEST_NONE);
   ui_test_utils::NavigateToURLBlockUntilNavigationsComplete(
       browser(), GURL("http://www.blocker.com"), 2);
 
-  const char* subset_one[] = {
+  const char* const subset_one[] = {
       "CreatedLink",
       "InnerHtml",
       "DocumentWrite"
   };
 
-  const char* subset_two[] = {
+  const char* const subset_two[] = {
       "ContentScript",
       "CreatedScript",
       "CreatedIframe",
       "CreatedDiv",
       "CreatedEmbed",
       "CreatedObject",
       "InvokedDomMethod"
   };
 
   // These were only touched by one of the scripts.
@@ skipping 22 matching lines @@
         google_histogram->SnapshotSamples();
     EXPECT_EQ(1, google_samples->GetCount(2));
 
     base::HistogramBase* cnn_histogram = base::Histogram::FactoryGet(
         std::string(kNonGooglePrefix) + "." + std::string(subset_two[i]),
         1, 100, 50, base::HistogramBase::kNoFlags);
     scoped_ptr<base::HistogramSamples> cnn_samples =
         cnn_histogram->SnapshotSamples();
     EXPECT_EQ(1, cnn_samples->GetCount(2));
   }
-
 }