Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 635573004: Don't readback and reupload texture-backed bitmaps (Closed)

Created:
6 years, 2 months ago by bsalomon
Modified:
6 years, 2 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Don't readback and reupload texture-backed bitmaps Committed: https://skia.googlesource.com/skia/+/b9ab5631703c258f1aae7a3ca1bb4b6596b5b42c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M src/gpu/SkGr.cpp View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
bsalomon
6 years, 2 months ago (2014-10-06 20:20:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/635573004/1
6 years, 2 months ago (2014-10-06 20:24:19 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-06 20:24:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac10.8-Clang-x86_64-Release-Trybot on tryserver.skia (http://108.170.220.76:10117/builders/Build-Mac10.8-Clang-x86_64-Release-Trybot/builds/1884)
6 years, 2 months ago (2014-10-06 21:50:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/635573004/1
6 years, 2 months ago (2014-10-07 01:00:57 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-07 01:00:58 UTC) #10
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
6 years, 2 months ago (2014-10-07 07:00:58 UTC) #12
robertphillips
lgtm
6 years, 2 months ago (2014-10-07 12:18:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/635573004/1
6 years, 2 months ago (2014-10-07 12:19:15 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1) as b9ab5631703c258f1aae7a3ca1bb4b6596b5b42c
6 years, 2 months ago (2014-10-07 12:19:28 UTC) #16
bsalomon
6 years, 2 months ago (2014-10-07 13:19:32 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/632293002/ by bsalomon@google.com.

The reason for reverting is: This fails on some Android devices, missing part of
tileimagefilter GM which were previously triggering the readback/upload code
path..

Powered by Google App Engine
This is Rietveld 408576698