Source/core/rendering/shapes/ShapeOutsideInfo.cpp - Issue 635533003: Don't delete nodes in the float interval tree while traversing it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/shapes/ShapeOutsideInfo.cpp

Issue 635533003: Don't delete nodes in the float interval tree while traversing it. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Added square.png and another test Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/shapes/ShapeOutsideInfo.cpp

diff --git a/Source/core/rendering/shapes/ShapeOutsideInfo.cpp b/Source/core/rendering/shapes/ShapeOutsideInfo.cpp

index f269bf875874f9555f7ff4be63c404d414825454..a3325f9ea2e777b4b6fd97143934b26291a2e2ec 100644

--- a/Source/core/rendering/shapes/ShapeOutsideInfo.cpp

+++ b/Source/core/rendering/shapes/ShapeOutsideInfo.cpp

@@ -142,6 +142,7 @@ const Shape& ShapeOutsideInfo::computedShape() const

if (Shape* shape = m_shape.get())

return *shape;

+ m_computingShape = true;

Julien - ping for review 2014/10/08 18:13:27 TemporaryChange<bool> isInComputingShape(m_computi

const RenderStyle& style = *m_renderer.style();

ASSERT(m_renderer.containingBlock());

const RenderStyle& containingBlockStyle = *m_renderer.containingBlock()->style();

@@ -170,6 +171,7 @@ const Shape& ShapeOutsideInfo::computedShape() const

}

+ m_computingShape = false;

ASSERT(m_shape);

return *m_shape;

}