Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 63553009: Initialize DomDistillerStore (Closed)

Created:
7 years, 1 month ago by Yaron
Modified:
7 years, 1 month ago
Reviewers:
cjhopman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, nyquist
Visibility:
Public.

Description

Initialize DomDistillerStore Needed as part of setting up the DomDistillerBrowserContextKeyedService. Distilled articles will be stored in an "Articles" directory in the user's profile directory. BUG=288015 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235562 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235799

Patch Set 1 #

Patch Set 2 : add include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -6 lines) Patch
M components/dom_distiller/content/dom_distiller_service_factory.cc View 1 2 chunks +24 lines, -5 lines 0 comments Download
M components/dom_distiller/core/dom_distiller_store.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Yaron
7 years, 1 month ago (2013-11-15 19:00:12 UTC) #1
cjhopman
lgtm
7 years, 1 month ago (2013-11-15 19:11:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/63553009/1
7 years, 1 month ago (2013-11-15 19:40:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/63553009/1
7 years, 1 month ago (2013-11-15 22:00:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/63553009/1
7 years, 1 month ago (2013-11-16 00:28:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/63553009/1
7 years, 1 month ago (2013-11-17 19:55:53 UTC) #6
commit-bot: I haz the power
Change committed as 235562
7 years, 1 month ago (2013-11-17 21:42:58 UTC) #7
Yaron
On 2013/11/17 21:42:58, I haz the power (commit-bot) wrote: > Change committed as 235562 This ...
7 years, 1 month ago (2013-11-18 19:40:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/63553009/270001
7 years, 1 month ago (2013-11-18 19:45:42 UTC) #9
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 19:51:51 UTC) #10
Message was sent while issue was closed.
Change committed as 235799

Powered by Google App Engine
This is Rietveld 408576698