Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 635523002: Replacing the OVERRIDE with override and FINAL with final in /src/ios (Closed)

Created:
6 years, 2 months ago by anujsharma
Modified:
6 years, 2 months ago
Reviewers:
blundell
CC:
chromium-reviews, MRV, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replacing the OVERRIDE with override and FINAL with final in /src/ios This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://crrev.com/cad9df6c5a33f1d48945fc81fe08fad9de25ce34 Cr-Commit-Position: refs/heads/master@{#298448}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M ios/consumer/base/supports_user_data_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/public/test/fake_profile_oauth2_token_service_ios_provider.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
anujsharma
PTAL
6 years, 2 months ago (2014-10-06 12:47:20 UTC) #2
blundell
lgtm
6 years, 2 months ago (2014-10-07 11:55:37 UTC) #3
anujsharma
On 2014/10/07 11:55:37, blundell wrote: > lgtm Thanks blundell for lgtm.
6 years, 2 months ago (2014-10-07 12:04:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/635523002/1
6 years, 2 months ago (2014-10-07 12:04:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 38511a98984136528f98d50fe0f630e689241c0a
6 years, 2 months ago (2014-10-07 13:00:41 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 13:01:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cad9df6c5a33f1d48945fc81fe08fad9de25ce34
Cr-Commit-Position: refs/heads/master@{#298448}

Powered by Google App Engine
This is Rietveld 408576698