Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 635503002: Replacing the OVERRIDE with override and FINAL with final in content/browser/shared_worker (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replacing the OVERRIDE with override and FINAL with final in content/browser/shared_worker This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://crrev.com/4bc30c3ad66e3934c10c59b8fac217298cec27e1 Cr-Commit-Position: refs/heads/master@{#298253}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M content/browser/shared_worker/shared_worker_message_filter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-06 13:10:51 UTC) #2
Avi (use Gerrit)
On 2014/10/06 13:10:51, MRV wrote: > PTAL LGTM
6 years, 2 months ago (2014-10-06 15:01:30 UTC) #3
MRV
On 2014/10/06 15:01:30, Avi wrote: > On 2014/10/06 13:10:51, MRV wrote: > > PTAL > ...
6 years, 2 months ago (2014-10-06 15:44:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/635503002/1
6 years, 2 months ago (2014-10-06 15:45:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as ffd07931a13685b9f67b640dbe1a7320d875fe07
6 years, 2 months ago (2014-10-06 17:11:19 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-06 17:11:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4bc30c3ad66e3934c10c59b8fac217298cec27e1
Cr-Commit-Position: refs/heads/master@{#298253}

Powered by Google App Engine
This is Rietveld 408576698