Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 635473002: Fix when fast/events/message-port-gc-closed.html forces a GC. (Closed)

Created:
6 years, 2 months ago by sof
Modified:
6 years, 2 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Fix when fast/events/message-port-gc-closed.html forces a GC. Delay the garbage collection until the event handler invocation has returned. R=haraken BUG=420061 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183263

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M LayoutTests/fast/events/message-port-gc-closed.html View 1 chunk +11 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
sof
Please take a look.
6 years, 2 months ago (2014-10-06 10:29:07 UTC) #2
haraken
LGTM
6 years, 2 months ago (2014-10-06 11:41:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/635473002/1
6 years, 2 months ago (2014-10-06 11:43:18 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-06 12:33:29 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183263

Powered by Google App Engine
This is Rietveld 408576698