Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 635443002: Make platform depend on openmax_dl. (Closed)

Created:
6 years, 2 months ago by ajm
Modified:
6 years, 2 months ago
CC:
blink-reviews, mkwst+moarreviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Make platform depend on openmax_dl. This is required for upcoming openmax_dl changes here: https://codereview.chromium.org/626183003 but I believe should be done in any case. BUG=415393 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183311

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M Source/platform/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
ajm
Raymond, as I've never committed to blink before, is this Base URL fine? And for ...
6 years, 2 months ago (2014-10-06 05:54:41 UTC) #2
ajm
Ah, I should also point out that this can be landed before the openmax_dl changes. ...
6 years, 2 months ago (2014-10-06 05:56:17 UTC) #3
Raymond Toy
lgtm. But I've never done any work with the gn files.
6 years, 2 months ago (2014-10-06 16:16:11 UTC) #4
ajm
Henrik, could you have a quick look?
6 years, 2 months ago (2014-10-06 16:52:21 UTC) #5
kjellander_chromium
On 2014/10/06 16:52:21, ajm wrote: > Henrik, could you have a quick look? +brettw Brett, ...
6 years, 2 months ago (2014-10-06 17:28:27 UTC) #7
brettw
lgtm
6 years, 2 months ago (2014-10-06 22:37:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/635443002/1
6 years, 2 months ago (2014-10-07 00:41:35 UTC) #10
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 2 months ago (2014-10-07 02:42:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/635443002/1
6 years, 2 months ago (2014-10-07 06:49:29 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 06:50:11 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183311

Powered by Google App Engine
This is Rietveld 408576698