Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 63543005: Fix crash in tests on valgrind bot (Closed)

Created:
7 years, 1 month ago by robertphillips
Modified:
7 years, 1 month ago
Reviewers:
jvanverth1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

I believe this will fix the following crash on the valgrind bot: Failed to open X display. Invalid read of size 8 at 0x5813E3: SkSurface::getCanvas() (SkSurface_Base.h:75) by 0x495D8B: skiatest::SurfaceTestClass::onRun(skiatest::Reporter*) (SurfaceTest.cpp:159) by 0x4966F2: skiatest::Test::run() (Test.cpp:109) by 0x48FD90: SkTestRunnable::run() (skia_test.cpp:155) by 0x48F736: tool_main(int, char**) (skia_test.cpp:246) by 0x48F912: main (skia_test.cpp:276) Address 0x18 is not stack'd, malloc'd or (recently) free'd Process terminating with default action of signal 11 (SIGSEGV) Access not within mapped region at address 0x18 at 0x5813E3: SkSurface::getCanvas() (SkSurface_Base.h:75) by 0x495D8B: skiatest::SurfaceTestClass::onRun(skiatest::Reporter*) (SurfaceTest.cpp:159) by 0x4966F2: skiatest::Test::run() (Test.cpp:109) by 0x48FD90: SkTestRunnable::run() (skia_test.cpp:155) by 0x48F736: tool_main(int, char**) (skia_test.cpp:246) by 0x48F912: main (skia_test.cpp:276)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M tests/SurfaceTest.cpp View 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
robertphillips
7 years, 1 month ago (2013-11-11 20:09:55 UTC) #1
jvanverth1
lgtm
7 years, 1 month ago (2013-11-12 13:42:23 UTC) #2
robertphillips
7 years, 1 month ago (2013-11-12 13:51:18 UTC) #3
Message was sent while issue was closed.
committed as r12234

Powered by Google App Engine
This is Rietveld 408576698