Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/object.h

Issue 635393002: Fix Object::Clone. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | runtime/vm/object.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.h
===================================================================
--- runtime/vm/object.h (revision 40925)
+++ runtime/vm/object.h (working copy)
@@ -315,8 +315,6 @@
bool IsNotTemporaryScopedHandle() const;
- static RawObject* Clone(const Object& src, Heap::Space space = Heap::kNew);
-
static Object& Handle(Isolate* isolate, RawObject* raw_ptr) {
Object* obj = reinterpret_cast<Object*>(VMHandles::AllocateHandle(isolate));
initializeHandle(obj, raw_ptr);
@@ -619,6 +617,9 @@
void UnimplementedMethod() const;
#undef STORE_NON_POINTER_ILLEGAL_TYPE
+ // Allocate an object and copy the body of 'src', but not its header.
Ivan Posva 2014/10/10 20:59:04 ", but not its header" is redundant.
+ static RawObject* Clone(const Object& src, Heap::Space space);
+
RawObject* raw_; // The raw object reference.
protected:
« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | runtime/vm/object.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698