Fix Object::Clone.

runtime/vm/object.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_OBJECT_H_
 #define VM_OBJECT_H_
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/utils.h"
@@ skipping 297 matching lines @@
   void Print() const;
 
   bool IsZoneHandle() const {
     return VMHandles::IsZoneHandle(reinterpret_cast<uword>(this));
   }
 
   bool IsReadOnlyHandle() const;
 
   bool IsNotTemporaryScopedHandle() const;
 
-  static RawObject* Clone(const Object& src, Heap::Space space = Heap::kNew);
-
   static Object& Handle(Isolate* isolate, RawObject* raw_ptr) {
     Object* obj = reinterpret_cast<Object*>(VMHandles::AllocateHandle(isolate));
     initializeHandle(obj, raw_ptr);
     return *obj;
   }
   static Object* ReadOnlyHandle() {
     Object* obj = reinterpret_cast<Object*>(
         Dart::AllocateReadOnlyHandle());
     initializeHandle(obj, Object::null());
     return obj;
@@ skipping 282 matching lines @@
   // Fail at link time if StoreNonPointer is called with an object pointer.
 #define STORE_NON_POINTER_ILLEGAL_TYPE(type)                                   \
   template<typename ValueType>                                                 \
   void StoreNonPointer(Raw##type** addr, ValueType value) const {              \
     UnimplementedMethod();                                                     \
   }
   CLASS_LIST(STORE_NON_POINTER_ILLEGAL_TYPE);
   void UnimplementedMethod() const;
 #undef STORE_NON_POINTER_ILLEGAL_TYPE
 
+  // Allocate an object and copy the body of 'src'.
+  static RawObject* Clone(const Object& src, Heap::Space space);

[Ivan Posva, 2014/10/10 20:59:04]

Please match .cc and .h parameter names.

+
   RawObject* raw_;  // The raw object reference.
 
  protected:
   virtual void PrintJSONImpl(JSONStream* stream, bool ref) const;
 
  private:
   static intptr_t NextFieldOffset() {
     // Indicates this class cannot be extended by dart code.
     return -kWordSize;
   }
@@ skipping 6881 matching lines @@
 
 
 RawObject* MegamorphicCache::GetTargetFunction(const Array& array,
                                                intptr_t index) {
   return array.At((index * kEntryLength) + kTargetFunctionIndex);
 }
 
 }  // namespace dart
 
 #endif  // VM_OBJECT_H_