Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 635253002: Apply automatic range checks to content enum types across IPC. (Closed)

Created:
6 years, 2 months ago by anujsharma
Modified:
6 years, 2 months ago
CC:
chromium-reviews, MRV
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Apply automatic range checks to content enum types across IPC. This is part of a long-running background task to remove the remaining uses of the unchecked IPC_ENUM_TRAITS() macro. BUG=246708 Committed: https://crrev.com/098510bfbef457641abed93223f5294c13c2cd74 Cr-Commit-Position: refs/heads/master@{#298923}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/common/chrome_utility_printing_messages.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M printing/pwg_raster_settings.h View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 17 (4 generated)
anujsharma
vitalybuka@chromium.org: Please review changes in printing module nasko@chromium.org: Please review changes in chrome module
6 years, 2 months ago (2014-10-08 10:37:53 UTC) #2
nasko
https://codereview.chromium.org/635253002/diff/1/chrome/common/chrome_utility_printing_messages.h File chrome/common/chrome_utility_printing_messages.h (right): https://codereview.chromium.org/635253002/diff/1/chrome/common/chrome_utility_printing_messages.h#newcode53 chrome/common/chrome_utility_printing_messages.h:53: printing::PWG_RASTER_TRANSFORM_TYPE_LAST) Please align vertically the two lines. Refer to ...
6 years, 2 months ago (2014-10-08 17:20:51 UTC) #3
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/635253002/diff/1/printing/pwg_raster_settings.h File printing/pwg_raster_settings.h (right): https://codereview.chromium.org/635253002/diff/1/printing/pwg_raster_settings.h#newcode20 printing/pwg_raster_settings.h:20: PWG_RASTER_TRANSFORM_TYPE_LAST = TRANSFORM_FLIP_VERTICAL TRANSFORM_TYPE_LAST
6 years, 2 months ago (2014-10-08 17:40:05 UTC) #4
anujsharma
On 2014/10/08 17:40:05, Vitaly Buka wrote: > https://codereview.chromium.org/635253002/diff/1/printing/pwg_raster_settings.h > File printing/pwg_raster_settings.h (right): > > https://codereview.chromium.org/635253002/diff/1/printing/pwg_raster_settings.h#newcode20 ...
6 years, 2 months ago (2014-10-09 02:37:51 UTC) #5
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 2 months ago (2014-10-09 03:59:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/635253002/20001
6 years, 2 months ago (2014-10-09 04:01:20 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/16524)
6 years, 2 months ago (2014-10-09 04:11:48 UTC) #10
anujsharma
On 2014/10/09 04:11:48, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 2 months ago (2014-10-09 04:25:14 UTC) #11
nasko
lgtm
6 years, 2 months ago (2014-10-09 16:44:14 UTC) #12
anujsharma
On 2014/10/09 16:44:14, nasko wrote: > lgtm Thanks nasko for lgtm.
6 years, 2 months ago (2014-10-09 16:51:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/635253002/20001
6 years, 2 months ago (2014-10-09 16:52:53 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-09 17:25:43 UTC) #16
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 17:26:08 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/098510bfbef457641abed93223f5294c13c2cd74
Cr-Commit-Position: refs/heads/master@{#298923}

Powered by Google App Engine
This is Rietveld 408576698