Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Unified Diff: athena/extensions/chrome/extensions_delegate_impl.cc

Issue 635233008: Make management.launchApp() work for hosted apps on Athena (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webstore_dialogs_athena
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/BUILD.gn » ('j') | chrome/browser/ui/athena/extensions/DEPS » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: athena/extensions/chrome/extensions_delegate_impl.cc
diff --git a/athena/extensions/chrome/extensions_delegate_impl.cc b/athena/extensions/chrome/extensions_delegate_impl.cc
index 0d63e50bd2a167fd634a51f01e0be37b87215b6e..9883d42b2eb4e54c70f1c22a8692aa1c3c47a544 100644
--- a/athena/extensions/chrome/extensions_delegate_impl.cc
+++ b/athena/extensions/chrome/extensions_delegate_impl.cc
@@ -4,7 +4,6 @@
#include "athena/extensions/public/extensions_delegate.h"
-#include "athena/activity/public/activity_factory.h"
#include "athena/extensions/chrome/athena_chrome_app_window_client.h"
#include "base/macros.h"
#include "base/strings/utf_string_conversions.h"
@@ -75,12 +74,7 @@ class ChromeExtensionsDelegate : public ExtensionsDelegate {
}
params.container = extensions::LAUNCH_CONTAINER_WINDOW;
- // V2 apps
- if (CanLaunchViaEvent(extension)) {
- OpenApplication(params);
- return true;
- }
- LaunchV1App(params, extension);
+ OpenApplication(params);
return true;
}
@@ -89,17 +83,6 @@ class ChromeExtensionsDelegate : public ExtensionsDelegate {
return false;
}
- void LaunchV1App(const AppLaunchParams& params,
- const extensions::Extension* extension) {
- // TODO(oshima): Just activate if the app is already running.
- const GURL url_input = params.override_url;
-
- DCHECK(!url_input.is_empty() || extension);
- GURL url = UrlForExtension(extension, url_input);
- athena::ActivityFactory::Get()->CreateWebActivity(
- GetBrowserContext(), base::UTF8ToUTF16(extension->name()), url);
- }
-
// ExtensionService for the browser context this is created for.
ExtensionService* extension_service_;
« no previous file with comments | « no previous file | chrome/browser/ui/BUILD.gn » ('j') | chrome/browser/ui/athena/extensions/DEPS » ('J')

Powered by Google App Engine
This is Rietveld 408576698