Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: chrome/browser/ui/extensions/app_launch_params.cc

Issue 635233008: Make management.launchApp() work for hosted apps on Athena (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webstore_dialogs_athena
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/extensions/app_launch_params.cc
diff --git a/chrome/browser/ui/extensions/app_launch_params.cc b/chrome/browser/ui/extensions/app_launch_params.cc
index 74ce425b27a4c7a6b53dae6f9dbbeb69348873bd..a8598753a3033869a7bd0eb2e63cea039b2bf2cc 100644
--- a/chrome/browser/ui/extensions/app_launch_params.cc
+++ b/chrome/browser/ui/extensions/app_launch_params.cc
@@ -1,337 +1,15 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/browser/ui/extensions/application_launch.h"
+#include "chrome/browser/ui/extensions/app_launch_params.h"
-#include <string>
-
-#include "apps/launcher.h"
-#include "base/command_line.h"
-#include "base/metrics/histogram.h"
-#include "base/strings/utf_string_conversions.h"
-#include "chrome/browser/app_mode/app_mode_utils.h"
-#include "chrome/browser/apps/per_app_settings_service.h"
-#include "chrome/browser/apps/per_app_settings_service_factory.h"
-#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/launch_util.h"
-#include "chrome/browser/extensions/tab_helper.h"
#include "chrome/browser/profiles/profile.h"
-#include "chrome/browser/ui/app_list/app_list_service.h"
-#include "chrome/browser/ui/browser.h"
-#include "chrome/browser/ui/browser_commands.h"
-#include "chrome/browser/ui/browser_finder.h"
-#include "chrome/browser/ui/browser_tabstrip.h"
-#include "chrome/browser/ui/browser_window.h"
-#include "chrome/browser/ui/extensions/extension_enable_flow.h"
-#include "chrome/browser/ui/extensions/extension_enable_flow_delegate.h"
-#include "chrome/browser/ui/tabs/tab_strip_model.h"
-#include "chrome/browser/web_applications/web_app.h"
-#include "chrome/common/chrome_switches.h"
-#include "chrome/common/extensions/manifest_handlers/app_launch_info.h"
-#include "chrome/common/url_constants.h"
-#include "content/public/browser/render_view_host.h"
-#include "content/public/browser/web_contents.h"
-#include "content/public/common/renderer_preferences.h"
#include "extensions/browser/extension_prefs.h"
-#include "extensions/browser/extension_registry.h"
-#include "extensions/browser/extension_system.h"
-#include "extensions/common/constants.h"
#include "extensions/common/extension.h"
-#include "extensions/common/features/feature.h"
-#include "extensions/common/features/feature_provider.h"
-#include "extensions/common/manifest_handlers/options_page_info.h"
-#include "ui/base/window_open_disposition.h"
-#include "ui/gfx/rect.h"
-
-#if defined(OS_MACOSX)
-#include "chrome/browser/ui/browser_commands_mac.h"
-#endif
-using content::WebContents;
-using extensions::Extension;
using extensions::ExtensionPrefs;
-using extensions::ExtensionRegistry;
-
-namespace {
-
-// Attempts to launch a packaged app, prompting the user to enable it if
-// necessary. If a prompt is required it will be shown inside the AppList.
-// This class manages its own lifetime.
-class EnableViaAppListFlow : public ExtensionEnableFlowDelegate {
- public:
- EnableViaAppListFlow(ExtensionService* service,
- Profile* profile,
- chrome::HostDesktopType desktop_type,
- const std::string& extension_id,
- const base::Closure& callback)
- : service_(service),
- profile_(profile),
- desktop_type_(desktop_type),
- extension_id_(extension_id),
- callback_(callback) {
- }
-
- virtual ~EnableViaAppListFlow() {
- }
-
- void Run() {
- DCHECK(!service_->IsExtensionEnabled(extension_id_));
- flow_.reset(new ExtensionEnableFlow(profile_, extension_id_, this));
- flow_->StartForCurrentlyNonexistentWindow(
- base::Bind(&EnableViaAppListFlow::ShowAppList, base::Unretained(this)));
- }
-
- private:
- gfx::NativeWindow ShowAppList() {
- AppListService* app_list_service = AppListService::Get(desktop_type_);
- app_list_service->Show();
- return app_list_service->GetAppListWindow();
- }
-
- // ExtensionEnableFlowDelegate overrides.
- virtual void ExtensionEnableFlowFinished() override {
- const Extension* extension =
- service_->GetExtensionById(extension_id_, false);
- if (!extension)
- return;
- callback_.Run();
- delete this;
- }
-
- virtual void ExtensionEnableFlowAborted(bool user_initiated) override {
- delete this;
- }
-
- ExtensionService* service_;
- Profile* profile_;
- chrome::HostDesktopType desktop_type_;
- std::string extension_id_;
- base::Closure callback_;
- scoped_ptr<ExtensionEnableFlow> flow_;
-
- DISALLOW_COPY_AND_ASSIGN(EnableViaAppListFlow);
-};
-
-const Extension* GetExtension(const AppLaunchParams& params) {
- if (params.extension_id.empty())
- return NULL;
- ExtensionRegistry* registry = ExtensionRegistry::Get(params.profile);
- return registry->GetExtensionById(params.extension_id,
- ExtensionRegistry::ENABLED |
- ExtensionRegistry::DISABLED |
- ExtensionRegistry::TERMINATED);
-}
-
-ui::WindowShowState DetermineWindowShowState(
- Profile* profile,
- extensions::LaunchContainer container,
- const Extension* extension) {
- if (!extension || container != extensions::LAUNCH_CONTAINER_WINDOW)
- return ui::SHOW_STATE_DEFAULT;
-
- if (chrome::IsRunningInForcedAppMode())
- return ui::SHOW_STATE_FULLSCREEN;
-
-#if defined(USE_ASH)
- // In ash, LAUNCH_TYPE_FULLSCREEN launches in a maximized app window and
- // LAUNCH_TYPE_WINDOW launches in a normal app window.
- extensions::LaunchType launch_type =
- extensions::GetLaunchType(ExtensionPrefs::Get(profile), extension);
- if (launch_type == extensions::LAUNCH_TYPE_FULLSCREEN)
- return ui::SHOW_STATE_MAXIMIZED;
- else if (launch_type == extensions::LAUNCH_TYPE_WINDOW)
- return ui::SHOW_STATE_NORMAL;
-#endif
-
- return ui::SHOW_STATE_DEFAULT;
-}
-
-WebContents* OpenApplicationWindow(const AppLaunchParams& params) {
- Profile* const profile = params.profile;
- const Extension* const extension = GetExtension(params);
- const GURL url_input = params.override_url;
-
- DCHECK(!url_input.is_empty() || extension);
- GURL url = UrlForExtension(extension, url_input);
- std::string app_name = extension ?
- web_app::GenerateApplicationNameFromExtensionId(extension->id()) :
- web_app::GenerateApplicationNameFromURL(url);
-
- gfx::Rect initial_bounds;
- if (!params.override_bounds.IsEmpty()) {
- initial_bounds = params.override_bounds;
- } else if (extension) {
- initial_bounds.set_width(
- extensions::AppLaunchInfo::GetLaunchWidth(extension));
- initial_bounds.set_height(
- extensions::AppLaunchInfo::GetLaunchHeight(extension));
- }
-
- Browser::CreateParams browser_params(
- Browser::CreateParams::CreateForApp(app_name,
- true /* trusted_source */,
- initial_bounds,
- profile,
- params.desktop_type));
-
- browser_params.initial_show_state = DetermineWindowShowState(profile,
- params.container,
- extension);
-
- Browser* browser = new Browser(browser_params);
-
- WebContents* web_contents = chrome::AddSelectedTabWithURL(
- browser, url, ui::PAGE_TRANSITION_AUTO_TOPLEVEL);
- web_contents->GetMutableRendererPrefs()->can_accept_load_drops = false;
- web_contents->GetRenderViewHost()->SyncRendererPrefs();
-
- browser->window()->Show();
-
- // TODO(jcampan): http://crbug.com/8123 we should not need to set the initial
- // focus explicitly.
- web_contents->SetInitialFocus();
- return web_contents;
-}
-
-WebContents* OpenApplicationTab(const AppLaunchParams& launch_params) {
- const Extension* extension = GetExtension(launch_params);
- CHECK(extension);
- Profile* const profile = launch_params.profile;
- WindowOpenDisposition disposition = launch_params.disposition;
-
- Browser* browser = chrome::FindTabbedBrowser(profile,
- false,
- launch_params.desktop_type);
- WebContents* contents = NULL;
- if (!browser) {
- // No browser for this profile, need to open a new one.
- browser = new Browser(Browser::CreateParams(Browser::TYPE_TABBED,
- profile,
- launch_params.desktop_type));
- browser->window()->Show();
- // There's no current tab in this browser window, so add a new one.
- disposition = NEW_FOREGROUND_TAB;
- } else {
- // For existing browser, ensure its window is shown and activated.
- browser->window()->Show();
- browser->window()->Activate();
- }
-
- extensions::LaunchType launch_type =
- extensions::GetLaunchType(ExtensionPrefs::Get(profile), extension);
- UMA_HISTOGRAM_ENUMERATION("Extensions.AppTabLaunchType", launch_type, 100);
-
- int add_type = TabStripModel::ADD_ACTIVE;
- if (launch_type == extensions::LAUNCH_TYPE_PINNED)
- add_type |= TabStripModel::ADD_PINNED;
-
- GURL extension_url = UrlForExtension(extension, launch_params.override_url);
- chrome::NavigateParams params(browser, extension_url,
- ui::PAGE_TRANSITION_AUTO_TOPLEVEL);
- params.tabstrip_add_types = add_type;
- params.disposition = disposition;
-
- if (disposition == CURRENT_TAB) {
- WebContents* existing_tab =
- browser->tab_strip_model()->GetActiveWebContents();
- TabStripModel* model = browser->tab_strip_model();
- int tab_index = model->GetIndexOfWebContents(existing_tab);
-
- existing_tab->OpenURL(content::OpenURLParams(
- extension_url,
- content::Referrer(existing_tab->GetURL(),
- blink::WebReferrerPolicyDefault),
- disposition, ui::PAGE_TRANSITION_LINK, false));
- // Reset existing_tab as OpenURL() may have clobbered it.
- existing_tab = browser->tab_strip_model()->GetActiveWebContents();
- if (params.tabstrip_add_types & TabStripModel::ADD_PINNED) {
- model->SetTabPinned(tab_index, true);
- // Pinning may have moved the tab.
- tab_index = model->GetIndexOfWebContents(existing_tab);
- }
- if (params.tabstrip_add_types & TabStripModel::ADD_ACTIVE)
- model->ActivateTabAt(tab_index, true);
-
- contents = existing_tab;
- } else {
- chrome::Navigate(&params);
- contents = params.target_contents;
- }
-
- // On Chrome OS the host desktop type for a browser window is always set to
- // HOST_DESKTOP_TYPE_ASH. On Windows 8 it is only the case for Chrome ASH
- // in metro mode.
- if (browser->host_desktop_type() == chrome::HOST_DESKTOP_TYPE_ASH) {
- // In ash, LAUNCH_FULLSCREEN launches in the OpenApplicationWindow function
- // i.e. it should not reach here.
- DCHECK(launch_type != extensions::LAUNCH_TYPE_FULLSCREEN);
- } else {
- // TODO(skerner): If we are already in full screen mode, and the user
- // set the app to open as a regular or pinned tab, what should happen?
- // Today we open the tab, but stay in full screen mode. Should we leave
- // full screen mode in this case?
- if (launch_type == extensions::LAUNCH_TYPE_FULLSCREEN &&
- !browser->window()->IsFullscreen()) {
-#if defined(OS_MACOSX)
- chrome::ToggleFullscreenWithChromeOrFallback(browser);
-#else
- chrome::ToggleFullscreenMode(browser);
-#endif
- }
- }
- return contents;
-}
-
-WebContents* OpenEnabledApplication(const AppLaunchParams& params) {
- const Extension* extension = GetExtension(params);
- if (!extension)
- return NULL;
- Profile* profile = params.profile;
-
- WebContents* tab = NULL;
- ExtensionPrefs* prefs = ExtensionPrefs::Get(profile);
- prefs->SetActiveBit(extension->id(), true);
-
- UMA_HISTOGRAM_ENUMERATION(
- "Extensions.AppLaunchContainer", params.container, 100);
-
- if (CanLaunchViaEvent(extension)) {
- // Remember what desktop the launch happened on so that when the app opens a
- // window we can open them on the right desktop.
- PerAppSettingsServiceFactory::GetForBrowserContext(profile)->
- SetDesktopLastLaunchedFrom(extension->id(), params.desktop_type);
-
- apps::LaunchPlatformAppWithCommandLine(
- profile, extension, params.command_line, params.current_directory);
- return NULL;
- }
-
- // Record v1 app launch. Platform app launch is recorded when dispatching
- // the onLaunched event.
- prefs->SetLastLaunchTime(extension->id(), base::Time::Now());
-
- switch (params.container) {
- case extensions::LAUNCH_CONTAINER_NONE: {
- NOTREACHED();
- break;
- }
- case extensions::LAUNCH_CONTAINER_PANEL:
- case extensions::LAUNCH_CONTAINER_WINDOW:
- tab = OpenApplicationWindow(params);
- break;
- case extensions::LAUNCH_CONTAINER_TAB: {
- tab = OpenApplicationTab(params);
- break;
- }
- default:
- NOTREACHED();
- break;
- }
- return tab;
-}
-
-} // namespace
AppLaunchParams::AppLaunchParams(Profile* profile,
const extensions::Extension* extension,
@@ -390,76 +68,3 @@ AppLaunchParams::AppLaunchParams(Profile* profile,
AppLaunchParams::~AppLaunchParams() {
}
-
-WebContents* OpenApplication(const AppLaunchParams& params) {
- return OpenEnabledApplication(params);
-}
-
-void OpenApplicationWithReenablePrompt(const AppLaunchParams& params) {
- const Extension* extension = GetExtension(params);
- if (!extension)
- return;
- Profile* profile = params.profile;
-
- ExtensionService* service =
- extensions::ExtensionSystem::Get(profile)->extension_service();
- if (!service->IsExtensionEnabled(extension->id()) ||
- extensions::ExtensionRegistry::Get(profile)->GetExtensionById(
- extension->id(), extensions::ExtensionRegistry::TERMINATED)) {
- (new EnableViaAppListFlow(
- service, profile, params.desktop_type, extension->id(),
- base::Bind(base::IgnoreResult(OpenEnabledApplication), params)))->Run();
- return;
- }
-
- OpenEnabledApplication(params);
-}
-
-WebContents* OpenAppShortcutWindow(Profile* profile,
- const GURL& url) {
- AppLaunchParams launch_params(
- profile,
- NULL, // this is a URL app. No extension.
- extensions::LAUNCH_CONTAINER_WINDOW,
- NEW_WINDOW);
- launch_params.override_url = url;
-
- WebContents* tab = OpenApplicationWindow(launch_params);
-
- if (!tab)
- return NULL;
-
- extensions::TabHelper::FromWebContents(tab)->UpdateShortcutOnLoadComplete();
-
- return tab;
-}
-
-bool CanLaunchViaEvent(const extensions::Extension* extension) {
- const extensions::FeatureProvider* feature_provider =
- extensions::FeatureProvider::GetAPIFeatures();
- extensions::Feature* feature = feature_provider->GetFeature("app.runtime");
- return feature->IsAvailableToExtension(extension).is_available();
-}
-
-GURL UrlForExtension(const Extension* extension, const GURL& override_url) {
- if (!extension)
- return override_url;
-
- GURL url;
- if (!override_url.is_empty()) {
- DCHECK(extension->web_extent().MatchesURL(override_url) ||
- override_url.GetOrigin() == extension->url());
- url = override_url;
- } else {
- url = extensions::AppLaunchInfo::GetFullLaunchURL(extension);
- }
-
- // For extensions lacking launch urls, determine a reasonable fallback.
- if (!url.is_valid()) {
- url = extensions::OptionsPageInfo::GetOptionsPage(extension);
- if (!url.is_valid())
- url = GURL(chrome::kChromeUIExtensionsURL);
- }
-
- return url;
-}

Powered by Google App Engine
This is Rietveld 408576698