chrome/browser/ui/athena/extensions/DEPS - Issue 635233008: Make management.launchApp() work for hosted apps on Athena

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/athena/extensions/DEPS

Issue 635233008: Make management.launchApp() work for hosted apps on Athena (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webstore_dialogs_athena

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ui/BUILD.gn ('k') | chrome/browser/ui/athena/extensions/application_launch_web_app_athena.cc » ('j') | chrome/browser/ui/athena/extensions/application_launch_web_app_athena.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 include_rules = [

	2 "+athena/activity/public",

	3 ]
	oshima 2014/10/17 19:49:02 nit: aybe we should use specific_include_rules? nit: aybe we should use specific_include_rules? pkotwicz 2014/10/20 19:37:42 I do not think that it is worth it. https://codere I do not think that it is worth it. https://codereview.chromium.org/634313004/ introduces DEPS here too
OLD	NEW