Source/modules/screen_orientation/ScreenOrientation.h - Issue 635233004: Replace FINAL and OVERRIDE with their C++11 counterparts in Source/modules

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/screen_orientation/ScreenOrientation.h

Issue 635233004: Replace FINAL and OVERRIDE with their C++11 counterparts in Source/modules (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/screen_orientation/LockOrientationCallback.h ('k') | Source/modules/screen_orientation/ScreenOrientationController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/screen_orientation/ScreenOrientation.h

diff --git a/Source/modules/screen_orientation/ScreenOrientation.h b/Source/modules/screen_orientation/ScreenOrientation.h

index 66ed21ae80feeefa6061c4b65cad989789b50a99..58ba47f9eecdfca071f61205d6047518da2b18d8 100644

--- a/Source/modules/screen_orientation/ScreenOrientation.h

+++ b/Source/modules/screen_orientation/ScreenOrientation.h

@@ -21,7 +21,7 @@ class ScriptPromise;

class ScriptState;

class ScreenOrientationController;

-class ScreenOrientation FINAL

+class ScreenOrientation final

: public RefCountedGarbageCollectedWillBeGarbageCollectedFinalized<ScreenOrientation>

, public EventTargetWithInlineData

, public DOMWindowProperty {

@@ -34,8 +34,8 @@ public:

virtual ~ScreenOrientation();

// EventTarget implementation.

- virtual const WTF::AtomicString& interfaceName() const OVERRIDE;

- virtual ExecutionContext* executionContext() const OVERRIDE;

+ virtual const WTF::AtomicString& interfaceName() const override;

+ virtual ExecutionContext* executionContext() const override;

String type() const;

unsigned short angle() const;

@@ -51,7 +51,7 @@ public:

// Helper being used by this class and LockOrientationCallback.

static const AtomicString& orientationTypeToString(WebScreenOrientationType);

- virtual void trace(Visitor*) OVERRIDE;

+ virtual void trace(Visitor*) override;

private:

explicit ScreenOrientation(LocalFrame*);