Source/modules/notifications/Notification.h - Issue 635233004: Replace FINAL and OVERRIDE with their C++11 counterparts in Source/modules

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/notifications/Notification.h

Issue 635233004: Replace FINAL and OVERRIDE with their C++11 counterparts in Source/modules (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/netinfo/WorkerNavigatorNetworkInformation.h ('k') | Source/modules/notifications/NotificationController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/notifications/Notification.h

diff --git a/Source/modules/notifications/Notification.h b/Source/modules/notifications/Notification.h

index 69252bd6eed52abdb4d995ac75352199e4b61b8d..0d355398f678fd7e23f3c0151f7d03988872766b 100644

--- a/Source/modules/notifications/Notification.h

+++ b/Source/modules/notifications/Notification.h

@@ -83,13 +83,13 @@ public:

static void requestPermission(ExecutionContext*, NotificationPermissionCallback* = nullptr);

// EventTarget interface.

- virtual ExecutionContext* executionContext() const OVERRIDE FINAL { return ActiveDOMObject::executionContext(); }

- virtual bool dispatchEvent(PassRefPtrWillBeRawPtr<Event>) OVERRIDE FINAL;

- virtual const AtomicString& interfaceName() const OVERRIDE;

+ virtual ExecutionContext* executionContext() const override final { return ActiveDOMObject::executionContext(); }

+ virtual bool dispatchEvent(PassRefPtrWillBeRawPtr<Event>) override final;

+ virtual const AtomicString& interfaceName() const override;

// ActiveDOMObject interface.

- virtual void stop() OVERRIDE;

- virtual bool hasPendingActivity() const OVERRIDE;

+ virtual void stop() override;

+ virtual bool hasPendingActivity() const override;

private:

Notification(const String& title, ExecutionContext*, NotificationClient*);