Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2157)

Unified Diff: Source/modules/filesystem/InspectorFileSystemAgent.cpp

Issue 635233004: Replace FINAL and OVERRIDE with their C++11 counterparts in Source/modules (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/filesystem/InspectorFileSystemAgent.h ('k') | Source/modules/filesystem/LocalFileSystem.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/filesystem/InspectorFileSystemAgent.cpp
diff --git a/Source/modules/filesystem/InspectorFileSystemAgent.cpp b/Source/modules/filesystem/InspectorFileSystemAgent.cpp
index 5e3f43be8c162eda31ee32f645e73a9908bf4610..2c339e910998b6a47be35663698f963e099bb1db 100644
--- a/Source/modules/filesystem/InspectorFileSystemAgent.cpp
+++ b/Source/modules/filesystem/InspectorFileSystemAgent.cpp
@@ -81,7 +81,7 @@ static const char fileSystemAgentEnabled[] = "fileSystemAgentEnabled";
namespace {
template<typename BaseCallback, typename Handler, typename Argument>
-class CallbackDispatcher FINAL : public BaseCallback {
+class CallbackDispatcher final : public BaseCallback {
public:
typedef bool (Handler::*HandlingMethod)(Argument);
@@ -90,7 +90,7 @@ public:
return new CallbackDispatcher(handler, handlingMethod);
}
- virtual void handleEvent(Argument argument) OVERRIDE
+ virtual void handleEvent(Argument argument) override
{
(m_handler.get()->*m_handlingMethod)(argument);
}
@@ -179,7 +179,7 @@ bool FileSystemRootRequest::didGetEntry(Entry* entry)
return true;
}
-class DirectoryContentRequest FINAL : public RefCounted<DirectoryContentRequest> {
+class DirectoryContentRequest final : public RefCounted<DirectoryContentRequest> {
WTF_MAKE_NONCOPYABLE(DirectoryContentRequest);
public:
static PassRefPtr<DirectoryContentRequest> create(PassRefPtrWillBeRawPtr<RequestDirectoryContentCallback> requestCallback, const String& url)
@@ -300,7 +300,7 @@ bool DirectoryContentRequest::didReadDirectoryEntries(const EntryHeapVector& ent
return true;
}
-class MetadataRequest FINAL : public RefCounted<MetadataRequest> {
+class MetadataRequest final : public RefCounted<MetadataRequest> {
WTF_MAKE_NONCOPYABLE(MetadataRequest);
public:
static PassRefPtr<MetadataRequest> create(PassRefPtrWillBeRawPtr<RequestMetadataCallback> requestCallback, const String& url)
@@ -373,7 +373,7 @@ bool MetadataRequest::didGetMetadata(Metadata* metadata)
return true;
}
-class FileContentRequest FINAL : public EventListener {
+class FileContentRequest final : public EventListener {
WTF_MAKE_NONCOPYABLE(FileContentRequest);
public:
static PassRefPtr<FileContentRequest> create(PassRefPtrWillBeRawPtr<RequestFileContentCallback> requestCallback, const String& url, bool readAsText, long long start, long long end, const String& charset)
@@ -388,12 +388,12 @@ public:
void start(ExecutionContext*);
- virtual bool operator==(const EventListener& other) OVERRIDE
+ virtual bool operator==(const EventListener& other) override
{
return this == &other;
}
- virtual void handleEvent(ExecutionContext*, Event* event) OVERRIDE
+ virtual void handleEvent(ExecutionContext*, Event* event) override
{
if (event->type() == EventTypeNames::load)
didRead();
@@ -497,7 +497,7 @@ void FileContentRequest::didRead()
reportResult(static_cast<FileError::ErrorCode>(0), &result, &m_charset);
}
-class DeleteEntryRequest FINAL : public RefCounted<DeleteEntryRequest> {
+class DeleteEntryRequest final : public RefCounted<DeleteEntryRequest> {
public:
static PassRefPtr<DeleteEntryRequest> create(PassRefPtrWillBeRawPtr<DeleteEntryCallback> requestCallback, const KURL& url)
{
@@ -513,14 +513,14 @@ public:
private:
// CallbackDispatcherFactory doesn't handle 0-arg handleEvent methods
- class VoidCallbackImpl FINAL : public VoidCallback {
+ class VoidCallbackImpl final : public VoidCallback {
public:
explicit VoidCallbackImpl(PassRefPtr<DeleteEntryRequest> handler)
: m_handler(handler)
{
}
- virtual void handleEvent() OVERRIDE
+ virtual void handleEvent() override
{
m_handler->didDeleteEntry();
}
« no previous file with comments | « Source/modules/filesystem/InspectorFileSystemAgent.h ('k') | Source/modules/filesystem/LocalFileSystem.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698