Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 635223006: bpf_dsl: Move {Bool,Result}ExprImpl definition into separate header (Closed)

Created:
6 years, 2 months ago by mdempsky
Modified:
6 years, 2 months ago
CC:
chromium-reviews, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

bpf_dsl: Move {Bool,Result}ExprImpl definition into separate header Now that "extern template class scoped_refptr<Opaque>" is supported, we no longer need to expose the class definitions for BoolExprImpl and ResultExprImpl to end users. BUG=414363 Committed: https://crrev.com/fb10cce5ca304e0ed40290c7dd2deaf303a7aecd Cr-Commit-Position: refs/heads/master@{#299507}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -34 lines) Patch
M sandbox/linux/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/linux/bpf_dsl/bpf_dsl.h View 3 chunks +5 lines, -34 lines 0 comments Download
M sandbox/linux/bpf_dsl/bpf_dsl.cc View 2 chunks +4 lines, -0 lines 0 comments Download
A sandbox/linux/bpf_dsl/bpf_dsl_impl.h View 1 chunk +54 lines, -0 lines 0 comments Download
M sandbox/linux/sandbox_linux.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
mdempsky
6 years, 2 months ago (2014-10-14 01:25:20 UTC) #2
leecam
lgtm
6 years, 2 months ago (2014-10-14 01:38:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/635223006/1
6 years, 2 months ago (2014-10-14 01:50:44 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 2 months ago (2014-10-14 01:50:46 UTC) #7
mdempsky
jorgelo: PTAL
6 years, 2 months ago (2014-10-14 01:54:55 UTC) #9
Jorge Lucangeli Obes
lgtm
6 years, 2 months ago (2014-10-14 15:51:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/635223006/1
6 years, 2 months ago (2014-10-14 17:27:48 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-14 17:57:07 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 17:58:07 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fb10cce5ca304e0ed40290c7dd2deaf303a7aecd
Cr-Commit-Position: refs/heads/master@{#299507}

Powered by Google App Engine
This is Rietveld 408576698