[NaCl SDK] nacl_io: Fix real_node when dealing with a windows terminal

native_client_sdk/src/libraries/ppapi_simple/ps_main.cc

Index: native_client_sdk/src/libraries/ppapi_simple/ps_main.cc
diff --git a/native_client_sdk/src/libraries/ppapi_simple/ps_main.cc b/native_client_sdk/src/libraries/ppapi_simple/ps_main.cc
index 8ab1213e53ce9b5a75fa32b74e1be864f69f8290..f9b8147be481fc409978fb118806898551f32954 100644
--- a/native_client_sdk/src/libraries/ppapi_simple/ps_main.cc
+++ b/native_client_sdk/src/libraries/ppapi_simple/ps_main.cc
@@ -42,8 +42,10 @@ int main(int argc, char* argv[]) {
 #endif
   // By default, or if not running in the browser we simply run the main
   // entry point directly, on the main thread.
-  nacl_io_init();
-  int rtn = PSUserMainGet()(argc, argv);
+  int rtn = nacl_io_init();
+  if (rtn != 0)

[binji, 2014/10/08 01:26:13]

Explicit ppapi_simple failure message here?

[Sam Clegg, 2014/10/08 02:01:02]

Using what mechanism.  If nacl_io init fails is there any point in writing to
stdout at this point?

[binji, 2014/10/08 18:22:24]

I was thinking a direct write to stderr. Does nacl_io_init always print an error
if it fails to initialize? Even if so, this could be a useful fallback so the
user can see quickly what is failing -- nacl_io_init.

+    return rtn;
+  rtn = PSUserMainGet()(argc, argv);
   nacl_io_uninit();
   return rtn;
 }