Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: sync/protocol/experiment_status.proto

Issue 635093002: [GCM] Updating GCM Status Syncer to the new Experiment Status pb (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing CR comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/protocol/BUILD.gn ('k') | sync/sync.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/protocol/experiment_status.proto
diff --git a/components/gcm_driver/proto/gcm_channel_status.proto b/sync/protocol/experiment_status.proto
similarity index 66%
rename from components/gcm_driver/proto/gcm_channel_status.proto
rename to sync/protocol/experiment_status.proto
index 4013feed1a5c98d1651a379d27246fa7a64a9b11..be4902d3b0e96078ec232f3115885531d7b49bd8 100644
--- a/components/gcm_driver/proto/gcm_channel_status.proto
+++ b/sync/protocol/experiment_status.proto
@@ -6,12 +6,9 @@ syntax = "proto2";
option optimize_for = LITE_RUNTIME;
-package gcm_proto;
+package sync_pb;
-// Flags for enabling the GCM feature.
-message GcmChannelFlags {
- optional bool enabled = 1;
-}
+import "experiments_specifics.proto";
// This request allows an unauthenticated client to check the status of the
// experiments which do not require user authentication. The status of an
@@ -29,6 +26,11 @@ message ExperimentStatusResponse {
// Minimal time to wait before issuing another request.
optional int32 poll_interval_seconds = 1 [default = 3600];
- // This flag is returned if and only if the client asks for gcm_channel.
- optional GcmChannelFlags gcm_channel = 2;
+ // The experiments that the client has asked for, with each experiment
+ // containing exactly one experiment flag. The client can inspect the
+ // embedded flag to obtain the experiment status. Note that the number of
+ // experiments should be less than or equal to the number of experiment_name
+ // sent in the request since it is possible that there is no experiment
+ // matching an experiment_name.
+ repeated ExperimentsSpecifics experiment = 2;
}
« no previous file with comments | « sync/protocol/BUILD.gn ('k') | sync/sync.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698