[GCM] Updates to GCMChannelStatusSyncer - UserAgent and server URL.

[GCM] Updates to GCMChannelStatusSyncer - UserAgent and server URL.

BUG=421208
R=zea@chromium.org

Committed: https://crrev.com/3f6b84cd4ebdc209f3d607f2336e6f43aadcd2df
Cr-Commit-Position: refs/heads/master@{#299185}

[fgorski, 2014-10-07 23:24:07]

PTAL.
This is the URL + UserAgent part.

[Nicolas Zea, 2014-10-08 00:40:41]

LGTM (although probably good to double check it works manually)

https://codereview.chromium.org/635073002/diff/1/components/gcm_driver/gcm_ch...
File components/gcm_driver/gcm_channel_status_syncer.h (right):

https://codereview.chromium.org/635073002/diff/1/components/gcm_driver/gcm_ch...
components/gcm_driver/gcm_channel_status_syncer.h:77: std::string
channel_status_request_url_;
nit: make both const

[fgorski, 2014-10-08 16:55:17]

I updated the url_ and user_agent_ to be const in both the syncer and the
request.

checking CQ bit.

https://codereview.chromium.org/635073002/diff/1/components/gcm_driver/gcm_ch...
File components/gcm_driver/gcm_channel_status_syncer.h (right):

https://codereview.chromium.org/635073002/diff/1/components/gcm_driver/gcm_ch...
components/gcm_driver/gcm_channel_status_syncer.h:77: std::string
channel_status_request_url_;
On 2014/10/08 00:40:41, Nicolas Zea wrote:
> nit: make both const

Done.

[fgorski, 2014-10-08 16:55:21]

The CQ bit was checked by fgorski@chromium.org

[commit-bot: I haz the power, 2014-10-08 16:57:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/635073002/20001

[fgorski, 2014-10-08 16:59:39]

The CQ bit was unchecked by fgorski@chromium.org

[fgorski, 2014-10-08 17:00:28]

On 2014/10/08 16:57:46, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/635073002/20001

Unchecking the bit to make a manual test (I'll need this and protobuf patch for
it).
I'll start testing as soon as Kevin is in.

[fgorski, 2014-10-10 21:02:54]

On 2014/10/08 17:00:28, fgorski wrote:
> On 2014/10/08 16:57:46, I haz the power (commit-bot) wrote:
> > CQ is trying da patch. Follow status at
> >  https://chromium-cq-status.appspot.com/patch-status/635073002/20001
> 
> Unchecking the bit to make a manual test (I'll need this and protobuf patch
for
> it).
> I'll start testing as soon as Kevin is in.

User Agent and URL seem to be picking up correctly. We just tested on Kevin's
private build.
Passing in gibberish in User Agent causes bad response.
Using incorrect address ends with 404.
Hitting the server properly allows to retrieve the gcm_channel is_enabled and
poll_interval properly.

This was tested together with protobuf change.

[fgorski, 2014-10-10 21:03:05]

The CQ bit was checked by fgorski@chromium.org

[commit-bot: I haz the power, 2014-10-10 21:03:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/635073002/20001

[commit-bot: I haz the power, 2014-10-10 21:04:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-10 21:05:10]

Patchset 2 (id:??) landed as
https://crrev.com/3f6b84cd4ebdc209f3d607f2336e6f43aadcd2df
Cr-Commit-Position: refs/heads/master@{#299185}