Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2041)

Unified Diff: components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc

Issue 635013003: Expose data reduction proxy auth token for internal builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add missing comma in BUILD.gn Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc
diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc b/components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc
index fc4819629c4e9a94a1132f99bc50ca1e6fe282e5..586262d9244f01aeae2be3ef3d30399faf101297 100644
--- a/components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc
+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc
@@ -23,6 +23,10 @@
#include "net/url_request/url_request.h"
#include "url/gurl.h"
+#if !defined(OS_ANDROID) && !defined(OS_IOS)
+#include "google_apis/google_api_keys.h"
+#endif
+
namespace data_reduction_proxy {
// The empty version for the authentication protocol. Currently used by
@@ -217,6 +221,14 @@ std::string DataReductionProxyAuthRequestHandler::GetDefaultKey() const {
if (key.empty())
key = SPDY_PROXY_AUTH_VALUE;
#endif
+
+#if !defined(OS_ANDROID) && !defined(OS_IOS)
bengr 2014/10/10 00:26:07 Presuming this doesn't bloat WebView or Cronet, ca
Not at Google. Contact bengr 2014/10/10 18:55:43 It will increase the size by about 1.4M. Also the
+ // On Android and iOS this value is obtained from supplement.gypi. We avoid
bengr 2014/10/10 00:26:06 I wouldn't describe how internal code works. Inste
Not at Google. Contact bengr 2014/10/10 18:55:43 Done.
+ // this dependency when possible to reduce the size of this component.
+ if (key.empty()) {
+ key = google_apis::GetSpdyProxyAuthValue();
+ }
+#endif
return key;
}

Powered by Google App Engine
This is Rietveld 408576698