components/data_reduction_proxy/DEPS - Issue 635013003: Expose data reduction proxy auth token for internal builds.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/data_reduction_proxy/DEPS

Issue 635013003: Expose data reduction proxy auth token for internal builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add missing comma in BUILD.gn Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | components/data_reduction_proxy/browser/BUILD.gn » ('j') | components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+components/pref_registry",	2 "+components/pref_registry",

3 "+crypto",	3 "+crypto",

	4 "+google_apis",
	bengr 2014/10/10 00:26:06 I am ok with this only if this does not signific I am ok with this only if this does not significantly increase the code size for data reduction proxy clients that do not already use google_apis. Please verify that this is the case by measuring the code size of cronet before and after this change (you'll have to add data reduction proxy objects to cronet). If webview does not currently use google_apis, you could measure the code size of it instead. It already has data reduction proxy support. Not at Google. Contact bengr 2014/10/10 17:09:07 The size of libgoogle_apis.a is 1.4MB. I would exp Show quoted text On 2014/10/10 00:26:06, bengr1 wrote: > I am ok with this only if this does not significantly increase the code size > for data reduction proxy clients that do not already use google_apis. Please > verify that this is the case by measuring the code size of cronet before and > after this change (you'll have to add data reduction proxy objects to cronet). > If webview does not currently use google_apis, you could measure the code size > of it instead. It already has data reduction proxy support. The size of libgoogle_apis.a is 1.4MB. I would expect that this would be the size increase when it is linked in. Is this too high? Not at Google. Contact bengr 2014/10/10 18:55:43 Unable to build the cronet since it gives random e Show quoted text On 2014/10/10 00:26:06, bengr1 wrote: > I am ok with this only if this does not significantly increase the code size > for data reduction proxy clients that do not already use google_apis. Please > verify that this is the case by measuring the code size of cronet before and > after this change (you'll have to add data reduction proxy objects to cronet). > If webview does not currently use google_apis, you could measure the code size > of it instead. It already has data reduction proxy support. Unable to build the cronet since it gives random errors. Not sure how stable that target is. I made the gyp and gn rules so that the dependency to google_api is only for non-mobile.
4 "+net",	5 "+net",

5 ]	6 ]

OLD	NEW