Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 635013002: Remove implicit conversions from scoped_refptr to T* in remoting/ (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
weitao, garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in remoting/ This patch was generated by running the rewrite_scoped_refptr clang tool on an Android build. BUG=110610 Committed: https://crrev.com/442517ec3f796a41041ce11ff00210a19ffbb919 Cr-Commit-Position: refs/heads/master@{#298567}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M remoting/client/jni/chromoting_jni_runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/jni/chromoting_jni_runtime.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dcheng
6 years, 2 months ago (2014-10-07 19:59:40 UTC) #2
weitao
LGTM
6 years, 2 months ago (2014-10-07 20:16:15 UTC) #5
weitao
LGTM
6 years, 2 months ago (2014-10-07 20:16:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/635013002/1
6 years, 2 months ago (2014-10-07 20:20:23 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as a7eb519228859da719a22c436ac9a0fd57526552
6 years, 2 months ago (2014-10-07 20:56:00 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 20:56:50 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/442517ec3f796a41041ce11ff00210a19ffbb919
Cr-Commit-Position: refs/heads/master@{#298567}

Powered by Google App Engine
This is Rietveld 408576698