Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 634983003: Yield HTMLDocumentParser for high priority tasks in blink scheduler. (Closed)

Created:
6 years, 2 months ago by kouhei (in TOK)
Modified:
6 years, 2 months ago
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, adamk
Project:
blink
Visibility:
Public.

Description

Yield HTMLDocumentParser for high priority tasks in blink scheduler. Before this CL, main thread continued to process chunks from background parser when there were pending high priority tasks. This CL changes HTMLDocumentParser to query blink scheduler so we can yield when more high priority tasks are queued. BUG=421300 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183407

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/core/html/parser/HTMLDocumentParser.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
kouhei (in TOK)
6 years, 2 months ago (2014-10-08 03:40:43 UTC) #2
eseidel
This seems like a good idea, but ideally this is the HTMLParserScheduler's job to decide ...
6 years, 2 months ago (2014-10-08 03:52:22 UTC) #3
kouhei (in TOK)
On 2014/10/08 03:52:22, eseidel wrote: > This seems like a good idea, but ideally this ...
6 years, 2 months ago (2014-10-08 04:22:35 UTC) #4
Sami
Great, lgtm. Another thing to consider is hooking this up to use the idle task ...
6 years, 2 months ago (2014-10-08 10:21:11 UTC) #5
kouhei (in TOK)
Thanks for review!
6 years, 2 months ago (2014-10-08 11:35:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634983003/1
6 years, 2 months ago (2014-10-08 11:35:33 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-08 11:39:19 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183407

Powered by Google App Engine
This is Rietveld 408576698