scripts/slave/runtest.py - Issue 634933002: Enable telemetry --output-format=chartjson in recipes builds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/runtest.py

Issue 634933002: Enable telemetry --output-format=chartjson in recipes builds (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/runtest.py

diff --git a/scripts/slave/runtest.py b/scripts/slave/runtest.py

index 276b906aef509e822c56f301daec98843a491d04..be7324eae33d05bb80ad89efc0ebdd29dc77ab38 100755

--- a/scripts/slave/runtest.py

+++ b/scripts/slave/runtest.py

@@ -1583,11 +1583,6 @@ def _UpdateRunBenchmarkArgs(args):

None if not a telemetry test, otherwise a

dict containing the output filename and whether it is a reference build.

"""

- # TODO(sullivan): remove this line to enable new telemetry chartjson.

- # W0101: unreachable code. Disable this check until we're able to remove this

- # line entirely.

- # pylint: disable=W0101

- return {}

if not args[0].endswith('run_benchmark'):

# Not a telemetry run

return None

« no previous file with comments | « no previous file | no next file » | no next file with comments »