Wires up MotionEvents for mojo_shell_apk on Android.

Wires up MotionEvents for mojo_shell_apk on Android.

Receive Touch and Trackball events from our MojoViewport View and send them via NativeViewport to sample_app.
Note that I do not support multiple touchpoints right now. This is something I can easily add later but decided to start here.

BUG=
R=abarth@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233716

[Ben Goodger (Google), 2013-11-07 00:20:38]

Pending of course a real interface to do something more interesting than printf.

https://codereview.chromium.org/63493002/diff/40001/mojo/services/native_view...
File mojo/services/native_viewport/android/mojo_viewport.cc (right):

https://codereview.chromium.org/63493002/diff/40001/mojo/services/native_view...
mojo/services/native_viewport/android/mojo_viewport.cc:17: const int ACTION_DOWN
= 0;
I'm not sure if there's a better way to do this. The constant values are taken
from the docs.

[abarth-chromium, 2013-11-07 00:29:11]

https://codereview.chromium.org/63493002/diff/40001/mojo/services/native_view...
File mojo/services/native_viewport/android/mojo_viewport.cc (right):

https://codereview.chromium.org/63493002/diff/40001/mojo/services/native_view...
mojo/services/native_viewport/android/mojo_viewport.cc:17: const int ACTION_DOWN
= 0;
On 2013/11/07 00:20:38, Ben Goodger (Google) wrote:
> I'm not sure if there's a better way to do this. The constant values are taken
> from the docs.

Is there a header we can include to get these constants?  How do we do this in
content_shell?

https://codereview.chromium.org/63493002/diff/40001/mojo/services/native_view...
mojo/services/native_viewport/android/mojo_viewport.cc:47: 
You've got a blank line here.

https://codereview.chromium.org/63493002/diff/40001/mojo/services/native_view...
File
mojo/services/native_viewport/android/src/org/chromium/mojo/MojoViewport.java
(right):

https://codereview.chromium.org/63493002/diff/40001/mojo/services/native_view...
mojo/services/native_viewport/android/src/org/chromium/mojo/MojoViewport.java:92:
boolean isTouch,
Are there other possibilities?  I wonder if we should map the Java-to-native
function calls one-to-one.

[Ben Goodger (Google), 2013-11-07 01:04:35]

On Wed, Nov 6, 2013 at 4:29 PM, <abarth@chromium.org> wrote:

>
> https://codereview.chromium.org/63493002/diff/40001/mojo/
> services/native_viewport/android/mojo_viewport.cc
> File mojo/services/native_viewport/android/mojo_viewport.cc (right):
>
> https://codereview.chromium.org/63493002/diff/40001/mojo/
> services/native_viewport/android/mojo_viewport.cc#newcode17
> mojo/services/native_viewport/android/mojo_viewport.cc:17: const int
> ACTION_DOWN = 0;
> On 2013/11/07 00:20:38, Ben Goodger (Google) wrote:
>
>> I'm not sure if there's a better way to do this. The constant values
>>
> are taken
>
>> from the docs.
>>
>
> Is there a header we can include to get these constants?  How do we do
> this in content_shell?
>

Yes, android/input.h. I'll fix this.

>
> https://codereview.chromium.org/63493002/diff/40001/mojo/
> services/native_viewport/android/src/org/chromium/mojo/
> MojoViewport.java#newcode92
> mojo/services/native_viewport/android/src/org/chromium/mojo/
> MojoViewport.java:92:
> boolean isTouch,
> Are there other possibilities?  I wonder if we should map the
> Java-to-native function calls one-to-one.
>

I'll see if I can determine this from state. MotionEvent is a common event
class shared by Touch and Trackball event handlers. Will update later this
evening screamy baby permitting.

-Ben

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ben Goodger (Google), 2013-11-07 01:05:24]

On Wed, Nov 6, 2013 at 4:29 PM, <abarth@chromium.org> wrote:

>
> https://codereview.chromium.org/63493002/diff/40001/mojo/
> services/native_viewport/android/mojo_viewport.cc
> File mojo/services/native_viewport/android/mojo_viewport.cc (right):
>
> https://codereview.chromium.org/63493002/diff/40001/mojo/
> services/native_viewport/android/mojo_viewport.cc#newcode17
> mojo/services/native_viewport/android/mojo_viewport.cc:17: const int
> ACTION_DOWN = 0;
> On 2013/11/07 00:20:38, Ben Goodger (Google) wrote:
>
>> I'm not sure if there's a better way to do this. The constant values
>>
> are taken
>
>> from the docs.
>>
>
> Is there a header we can include to get these constants?  How do we do
> this in content_shell?
>

Yes, android/input.h. I'll fix this.

>
> https://codereview.chromium.org/63493002/diff/40001/mojo/
> services/native_viewport/android/src/org/chromium/mojo/
> MojoViewport.java#newcode92
> mojo/services/native_viewport/android/src/org/chromium/mojo/
> MojoViewport.java:92:
> boolean isTouch,
> Are there other possibilities?  I wonder if we should map the
> Java-to-native function calls one-to-one.
>

I'll see if I can determine this from state. MotionEvent is a common event
class shared by Touch and Trackball event handlers. Will update later this
evening screamy baby permitting.

-Ben

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ben Goodger (Google), 2013-11-07 22:14:48]

OK I updated this. Trackball events turn out to be slightly different from mouse
events, so I decided not to bother supporting them from now, not least of which
because the constants needed to support them in NDK don't appear to be in the
headers we have o_O...

[abarth-chromium, 2013-11-07 22:17:01]

lgtm

[Ben Goodger (Google), 2013-11-08 00:15:46]

Committed patchset #3 manually as r233716 (presubmit successful).