Issue 6349052: Implements Modulo operation on ARM for DoArithmeticD.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6349052: Implements Modulo operation on ARM for DoArithmeticD. (Closed)

Created:
9 years, 10 months ago by Rodolph Perfetta

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Implements Modulo operation on ARM for DoArithmeticD. BUG=none TEST=none Committed: http://code.google.com/p/v8/source/detail?r=6599

Patch Set 1 #

Total comments: 2

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
	M	src/arm/lithium-codegen-arm.cc	View		1 chunk	+12 lines, -1 line	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

9 years, 10 months ago (2011-02-03 09:00:23 UTC) #2

LGTM

I decided against the Push(r3, r2, r1, r0)

Committed: http://code.google.com/p/v8/source/detail?r=6599

http://codereview.chromium.org/6349052/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):

http://codereview.chromium.org/6349052/diff/1/src/arm/lithium-codegen-arm.cc#...
src/arm/lithium-codegen-arm.cc:1400: case Token::MOD: {
Please use Push(r3, r2, r1, r0)

http://codereview.chromium.org/6349052/diff/1/src/arm/lithium-codegen-arm.cc#...
src/arm/lithium-codegen-arm.cc:1411: // Restore r0-r3.
We currently don't have a Pop(r0, r1, r2, r4), so maybe using Push is a bad
idea.

Expand Messages | Collapse Messages