Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1275)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 634893002: Replace OVERRIDE and FINAL with override and final in WebKit/public (Closed)

Created:
6 years, 2 months ago by Vartul
Modified:
6 years, 2 months ago
Reviewers:
jamesr, Mike West, pfeldman
CC:
blink-reviews, shans, tzik, eric.carlson_apple.com, Mike Lawther (Google), apavlov+blink_chromium.org, rjwright, aandrey+blink_chromium.org, lushnikov+blink_chromium.org, Yoav Weiss, Steve Block, pfeldman+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, dstockwell, Timothy Loh, devtools-reviews_chromium.org, Eric Willigers, loislo+blink_chromium.org, philipj_slow, caseq+blink_chromium.org, timvolodine, feature-media-reviews_chromium.org, paulirish+reviews_chromium.org, nhiroki, darktears, dcheng, gavinp+prerender_chromium.org, eustas+blink_chromium.org, blink-reviews-animation_chromium.org, mkwst+moarreviews_chromium.org, vsevik+blink_chromium.org, mvanouwerkerk+watch_chromium.org, groby+blinkspell_chromium.org, sergeyv+blink_chromium.org, kinuko+fileapi
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Replace OVERRIDE and FINAL with override and final in WebKit/public BUG=417463 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183328

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1510 lines, -1510 lines) Patch
M Source/web/AssociatedURLLoader.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/web/AssociatedURLLoader.cpp View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/web/BackForwardClientImpl.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/web/ChromeClientImpl.h View 1 chunk +84 lines, -84 lines 0 comments Download
M Source/web/ColorChooserPopupUIController.h View 1 chunk +12 lines, -12 lines 0 comments Download
M Source/web/ColorChooserUIController.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/web/ContextFeaturesClientImpl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/ContextFeaturesClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ContextMenuClientImpl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/DatabaseClientImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/DateTimeChooserImpl.h View 1 chunk +11 lines, -11 lines 0 comments Download
M Source/web/DragClientImpl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/EditorClientImpl.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/web/ExternalDateTimeChooser.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/web/ExternalDateTimeChooser.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/ExternalPopupMenu.h View 2 chunks +10 lines, -10 lines 0 comments Download
M Source/web/ExternalPopupMenuTest.cpp View 3 chunks +21 lines, -21 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.h View 2 chunks +90 lines, -90 lines 0 comments Download
M Source/web/FullscreenController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/GeolocationClientProxy.h View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/web/GraphicsLayerFactoryChromium.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/IndexedDBClientImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/InspectorClientImpl.h View 1 chunk +37 lines, -37 lines 0 comments Download
M Source/web/LinkHighlight.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/web/LocalFileSystemClient.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/MIDIClientProxy.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/web/MediaKeysClientImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/NavigatorContentUtilsClientImpl.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/web/NotificationPermissionClientImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/NotificationPermissionClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/NotificationPresenterImpl.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/web/PageOverlay.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/PopupContainer.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/web/PopupContainerTest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/web/PopupListBox.h View 4 chunks +28 lines, -28 lines 0 comments Download
M Source/web/PopupMenuChromium.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/web/PopupMenuTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/PrerendererClientImpl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/RemoteFrameClientImpl.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/web/ScrollbarGroup.h View 2 chunks +27 lines, -27 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeClientImpl.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.h View 2 chunks +15 lines, -15 lines 0 comments Download
M Source/web/SharedWorkerRepositoryClientImpl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/web/SharedWorkerRepositoryClientImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/SpeechRecognitionClientProxy.h View 2 chunks +13 lines, -13 lines 0 comments Download
M Source/web/SpellCheckerClientImpl.h View 1 chunk +13 lines, -13 lines 0 comments Download
M Source/web/StorageClientImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/StorageQuotaClientImpl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/UserMediaClientImpl.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/web/ValidationMessageClientImpl.h View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/web/WebDOMActivityLogger.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/web/WebDataSourceImpl.h View 2 chunks +15 lines, -15 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.h View 2 chunks +37 lines, -37 lines 0 comments Download
M Source/web/WebDevToolsFrontendImpl.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/web/WebEmbeddedWorkerImpl.h View 3 chunks +14 lines, -14 lines 0 comments Download
M Source/web/WebEmbeddedWorkerImpl.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/web/WebFileChooserCompletionImpl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/WebFontImpl.h View 1 chunk +11 lines, -11 lines 0 comments Download
M Source/web/WebHelperPluginImpl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/WebKit.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebLeakDetector.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebLocalFrameImpl.h View 2 chunks +125 lines, -125 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/web/WebMediaPlayerClientImpl.h View 6 chunks +35 lines, -35 lines 0 comments Download
M Source/web/WebNodeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebPagePopupImpl.h View 2 chunks +18 lines, -18 lines 0 comments Download
M Source/web/WebPagePopupImpl.cpp View 3 chunks +17 lines, -17 lines 0 comments Download
M Source/web/WebPluginContainerImpl.h View 4 chunks +49 lines, -49 lines 0 comments Download
M Source/web/WebPluginScrollbarImpl.h View 2 chunks +26 lines, -26 lines 0 comments Download
M Source/web/WebPopupMenuImpl.h View 2 chunks +29 lines, -29 lines 0 comments Download
M Source/web/WebRemoteFrameImpl.h View 2 chunks +120 lines, -120 lines 0 comments Download
M Source/web/WebRemoteFrameImpl.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/web/WebSettingsImpl.h View 1 chunk +131 lines, -131 lines 0 comments Download
M Source/web/WebSharedWorkerImpl.h View 2 chunks +27 lines, -27 lines 0 comments Download
M Source/web/WebSharedWorkerImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebSocketChannelClientProxy.h View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/web/WebSocketImpl.h View 1 chunk +12 lines, -12 lines 0 comments Download
M Source/web/WebTextCheckingCompletionImpl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/WebViewImpl.h View 8 chunks +151 lines, -151 lines 0 comments Download
M Source/web/WorkerGlobalScopeProxyProviderImpl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/web/WorkerPermissionClient.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/tests/ActivityLoggerTest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/web/tests/FakeWebPlugin.h View 1 chunk +18 lines, -18 lines 0 comments Download
M Source/web/tests/FrameLoaderClientImplTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/FrameTestHelpers.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/web/tests/FrameTestHelpers.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/web/tests/ImeOnFocusTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/ListenerLeakTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/PrerenderingTest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/web/tests/ScrollAnimatorNoneTest.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/web/tests/TextFinderTest.cpp View 3 chunks +12 lines, -12 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 26 chunks +46 lines, -46 lines 0 comments Download
M Source/web/tests/WebHelperPluginTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/web/tests/WebPluginContainerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/WebViewTest.cpp View 9 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Vartul
Please review Thanks
6 years, 2 months ago (2014-10-07 11:42:57 UTC) #2
pfeldman
rs lgtm
6 years, 2 months ago (2014-10-07 11:50:12 UTC) #3
Mike West
LGTM
6 years, 2 months ago (2014-10-07 11:51:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634893002/1
6 years, 2 months ago (2014-10-07 11:54:17 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 13:08:51 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 183328

Powered by Google App Engine
This is Rietveld 408576698