Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 634843002: UA shadow root of <marquee> should not be exposed to user scripts

Created:
6 years, 2 months ago by haraken
Modified:
6 years, 2 months ago
Reviewers:
tasak, abarth-chromium
CC:
blink-reviews, blink-reviews-html_chromium.org, arv+blink, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, Inactive, rwlbuis
Project:
blink
Visibility:
Public.

Description

UA shadow root of <marquee> should not be exposed to user scripts This CL adds createUserAgentShadowRoot() as a private API. This private API is unavoidable to let private scripts implement builtin elements. BUG=420650 TEST=marquee-element-shadow-root.html

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
A LayoutTests/fast/html/marquee-element-shadow-root.html View 1 chunk +8 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/marquee-element-shadow-root-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/dom/Element.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/dom/Element.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLMarqueeElement.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
haraken
abarth@: PTAL at the private API. tasak@: PTAL.
6 years, 2 months ago (2014-10-07 05:34:53 UTC) #2
tasak
6 years, 2 months ago (2014-10-07 07:10:02 UTC) #3 
lgtm

Powered by Google App Engine
This is Rietveld 408576698