Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5127)

Unified Diff: chrome/browser/file_select_helper_unittest.cc

Issue 634833003: mac: Zip packages when they are selected by the file opener. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/file_select_helper_unittest.cc
diff --git a/chrome/browser/file_select_helper_unittest.cc b/chrome/browser/file_select_helper_unittest.cc
index 5eb0436957f75448ef797d6bd58d9ea11dfbcdee..d58263daa4049a55fa28f93a0387bbfc7f1fb113 100644
--- a/chrome/browser/file_select_helper_unittest.cc
+++ b/chrome/browser/file_select_helper_unittest.cc
@@ -2,10 +2,32 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "base/files/file_path.h"
+#include "base/files/file_util.h"
+#include "base/path_service.h"
#include "chrome/browser/file_select_helper.h"
+#include "chrome/common/chrome_paths.h"
#include "testing/gtest/include/gtest/gtest.h"
-TEST(FileSelectHelperTest, IsAcceptTypeValid) {
+class FileSelectHelperTest : public testing::Test {
+ public:
+ FileSelectHelperTest() {}
+
+ protected:
+ virtual void SetUp() OVERRIDE {
+ ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &data_dir_));
+ data_dir_ = data_dir_.AppendASCII("file_select_helper");
+ ASSERT_TRUE(base::PathExists(data_dir_));
+ }
+
+ // The path to input data used in tests.
+ base::FilePath data_dir_;
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(FileSelectHelperTest);
+};
+
+TEST_F(FileSelectHelperTest, IsAcceptTypeValid) {
EXPECT_TRUE(FileSelectHelper::IsAcceptTypeValid("a/b"));
EXPECT_TRUE(FileSelectHelper::IsAcceptTypeValid("abc/def"));
EXPECT_TRUE(FileSelectHelper::IsAcceptTypeValid("abc/*"));
@@ -17,3 +39,18 @@ TEST(FileSelectHelperTest, IsAcceptTypeValid) {
EXPECT_FALSE(FileSelectHelper::IsAcceptTypeValid("ABC/*"));
EXPECT_FALSE(FileSelectHelper::IsAcceptTypeValid("abc/def "));
}
+
+#if defined(OS_MACOSX) && !defined(OS_IOS)
+TEST_F(FileSelectHelperTest, ZipPackage) {
+ base::FilePath src = data_dir_.AppendASCII("CalculatorFake.app/");
+ base::FilePath dest = FileSelectHelper::ZipPackage(src);
+ EXPECT_FALSE(dest.empty());
+ EXPECT_TRUE(base::PathExists(dest));
+
+ base::FilePath expected_result =
+ data_dir_.AppendASCII("CalculatorFake.app.zip");
+ EXPECT_TRUE(base::ContentsEqual(dest, expected_result));
+
+ EXPECT_TRUE(base::DeleteFile(dest, false));
+}
+#endif // defined(OS_MACOSX) && !defined(OS_IOS)

Powered by Google App Engine
This is Rietveld 408576698