Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Unified Diff: printing/android/java/src/org/chromium/printing/PrintingController.java

Issue 63483007: Refactor Android printing code to make it more testable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add license to PrintingControllerFactory Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: printing/android/java/src/org/chromium/printing/PrintingController.java
diff --git a/printing/android/java/src/org/chromium/printing/PrintingController.java b/printing/android/java/src/org/chromium/printing/PrintingController.java
index beed86b335db232ba3325c7cb8c30839832dc403..76a2e5ac4b713a7c1bac7e8ab3a27a0cb9b4c570 100644
--- a/printing/android/java/src/org/chromium/printing/PrintingController.java
+++ b/printing/android/java/src/org/chromium/printing/PrintingController.java
@@ -62,7 +62,7 @@ public interface PrintingController {
void pageCountEstimationDone(final int maxPages);
/**
- * Sets PrintingContext.
+ * Sets PrintingContext currently associated with the controller.
*
* This needs to be called after PrintingContext object is created. Firstly its native
* counterpart is created, and then the Java. PrintingController implementation
@@ -71,14 +71,6 @@ public interface PrintingController {
void setPrintingContext(final PrintingContextInterface printingContext);
/**
- * TODO(cimamoglu): Remove errorText stuff once KitKat is public and we can move this code.
- * @param errorText The error message to be shown to user in case something goes wrong in PDF
- * generation in Chromium. We pass it here as a string because this folder
- * cannot use resources directly (or any other Clank code).
- */
- void setErrorText(final String errorText);
-
- /**
* @return Whether a complete PDF generation cycle inside Chromium has been completed.
*/
boolean hasPrintingFinished();

Powered by Google App Engine
This is Rietveld 408576698